Title: [272726] trunk/LayoutTests
Revision
272726
Author
[email protected]
Date
2021-02-11 07:25:20 -0800 (Thu, 11 Feb 2021)

Log Message

Add more Selenium key codes for test_driver.send_keys()
https://bugs.webkit.org/show_bug.cgi?id=221674

Reviewed by Carlos Garcia Campos.

LayoutTests/imported/w3c:

Add more Selenium key codes (https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html).
Not all of them are added, only the ones that are supported in eventSender.keyDown().

* web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Updated expectations
as this test was using the code for ENTER.
* web-platform-tests/resources/testdriver-vendor.js:

LayoutTests:

* platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (272725 => 272726)


--- trunk/LayoutTests/ChangeLog	2021-02-11 14:56:18 UTC (rev 272725)
+++ trunk/LayoutTests/ChangeLog	2021-02-11 15:25:20 UTC (rev 272726)
@@ -1,3 +1,12 @@
+2021-02-11  Manuel Rego Casasnovas  <[email protected]>
+
+        Add more Selenium key codes for test_driver.send_keys()
+        https://bugs.webkit.org/show_bug.cgi?id=221674
+
+        Reviewed by Carlos Garcia Campos.
+
+        * platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt.
+
 2021-02-11  Youenn Fablet  <[email protected]>
 
         Remove GPUProcess flag in MediaRecorder tests

Modified: trunk/LayoutTests/imported/w3c/ChangeLog (272725 => 272726)


--- trunk/LayoutTests/imported/w3c/ChangeLog	2021-02-11 14:56:18 UTC (rev 272725)
+++ trunk/LayoutTests/imported/w3c/ChangeLog	2021-02-11 15:25:20 UTC (rev 272726)
@@ -1,3 +1,17 @@
+2021-02-11  Manuel Rego Casasnovas  <[email protected]>
+
+        Add more Selenium key codes for test_driver.send_keys()
+        https://bugs.webkit.org/show_bug.cgi?id=221674
+
+        Reviewed by Carlos Garcia Campos.
+
+        Add more Selenium key codes (https://seleniumhq.github.io/selenium/docs/api/py/webdriver/selenium.webdriver.common.keys.html).
+        Not all of them are added, only the ones that are supported in eventSender.keyDown().
+
+        * web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt: Updated expectations
+        as this test was using the code for ENTER.
+        * web-platform-tests/resources/testdriver-vendor.js:
+
 2021-02-11  Ziran Sun  <[email protected]>
 
         the nested grid container which has replaced item with 'max-height' has wrong width(0px).

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt (272725 => 272726)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt	2021-02-11 14:56:18 UTC (rev 272725)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt	2021-02-11 15:25:20 UTC (rev 272726)
@@ -2,6 +2,6 @@
 
 
 
-FAIL Submit event with a submit button promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'event.bubbles')"
-FAIL Submit event with no submit button promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'event.bubbles')"
+FAIL Submit event with a submit button promise_test: Unhandled rejection with value: object "ReferenceError: Can't find variable: SubmitEvent"
+FAIL Submit event with no submit button assert_equals: expected (object) null but got (undefined) undefined
 

Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js (272725 => 272726)


--- trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js	2021-02-11 14:56:18 UTC (rev 272725)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js	2021-02-11 15:25:20 UTC (rev 272726)
@@ -157,15 +157,39 @@
     // FIXME: Add more cases.
     const SeleniumCharCodeToEventSenderKey = {
         0xE003: { key: 'delete' },
-        0xE004: { key: '\t' },
+        0XE004: { key: '\t' },
+        0XE005: { key: 'clear' },
+        0XE006: { key: '\r' },
+        0XE007: { key: 'enter' },
+        0xE008: { key: 'leftShift', modifier: 'shiftKey' },
+        0xE009: { key: 'leftControl', modifier: 'ctrlKey' },
+        0xE00A: { key: 'leftAlt', modifier: 'altKey' },
+        0XE00C: { key: 'escape' },
         0xE00D: { key: ' ' },
+        0XE00E: { key: 'pageUp' },
+        0XE00F: { key: 'pageDown' },
+        0XE010: { key: 'end' },
+        0XE011: { key: 'home' },
         0xE012: { key: 'leftArrow' },
         0xE013: { key: 'upArrow' },
         0xE014: { key: 'rightArrow' },
         0xE015: { key: 'downArrow' },
-        0xE008: { key: 'leftShift', modifier: 'shiftKey' },
-        0xE009: { key: 'leftControl', modifier: 'ctrlKey' },
-        0xE00A: { key: 'leftAlt', modifier: 'altKey' },
+        0XE016: { key: 'insert' },
+        0XE017: { key: 'delete' },
+        0XE018: { key: ';' },
+        0XE019: { key: '=' },
+        0XE031: { key: 'F1' },
+        0XE032: { key: 'F2' },
+        0XE033: { key: 'F3' },
+        0XE034: { key: 'F4' },
+        0XE035: { key: 'F5' },
+        0XE036: { key: 'F6' },
+        0XE037: { key: 'F7' },
+        0XE038: { key: 'F8' },
+        0XE039: { key: 'F9' },
+        0XE03A: { key: 'F10' },
+        0XE03B: { key: 'F11' },
+        0XE03C: { key: 'F12' },
         0xE03D: { key: 'leftMeta', modifier: 'metaKey' },
     };
 

Copied: trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt (from rev 272725, trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt) (0 => 272726)


--- trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/implicit-submission.optional-expected.txt	2021-02-11 15:25:20 UTC (rev 272726)
@@ -0,0 +1,7 @@
+
+
+
+
+FAIL Submit event with a submit button promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'event.bubbles')"
+FAIL Submit event with no submit button promise_test: Unhandled rejection with value: object "TypeError: undefined is not an object (evaluating 'event.bubbles')"
+
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to