Title: [273257] branches/safari-611-branch/Source/_javascript_Core
- Revision
- 273257
- Author
- [email protected]
- Date
- 2021-02-22 09:55:10 -0800 (Mon, 22 Feb 2021)
Log Message
Cherry-pick r270700. rdar://problem/74409412
REGRESSION (r270665): testapi failing on CLoop bot
https://bugs.webkit.org/show_bug.cgi?id=219787
Reviewed by Mark Lam.
The API has to special case the empty JSValue as null.
* API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsNull):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp (273256 => 273257)
--- branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp 2021-02-22 17:55:08 UTC (rev 273256)
+++ branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp 2021-02-22 17:55:10 UTC (rev 273257)
@@ -64,7 +64,7 @@
if (jsValue.isUndefined())
return kJSTypeUndefined;
- if (jsValue.isNull())
+ if (!jsValue || jsValue.isNull())
return kJSTypeNull;
if (jsValue.isBoolean())
return kJSTypeBoolean;
@@ -105,7 +105,7 @@
JSLockHolder locker(globalObject);
return toJS(globalObject, value).isNull();
#else
- return toJS(value).isNull();
+ return !value || toJS(value).isNull();
#endif
}
Modified: branches/safari-611-branch/Source/_javascript_Core/ChangeLog (273256 => 273257)
--- branches/safari-611-branch/Source/_javascript_Core/ChangeLog 2021-02-22 17:55:08 UTC (rev 273256)
+++ branches/safari-611-branch/Source/_javascript_Core/ChangeLog 2021-02-22 17:55:10 UTC (rev 273257)
@@ -1,5 +1,36 @@
2021-02-17 Ruben Turcios <[email protected]>
+ Cherry-pick r270700. rdar://problem/74409412
+
+ REGRESSION (r270665): testapi failing on CLoop bot
+ https://bugs.webkit.org/show_bug.cgi?id=219787
+
+ Reviewed by Mark Lam.
+
+ The API has to special case the empty JSValue as null.
+
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsNull):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-12-11 Tadeu Zagallo <[email protected]>
+
+ REGRESSION (r270665): testapi failing on CLoop bot
+ https://bugs.webkit.org/show_bug.cgi?id=219787
+
+ Reviewed by Mark Lam.
+
+ The API has to special case the empty JSValue as null.
+
+ * API/JSValueRef.cpp:
+ (JSValueGetType):
+ (JSValueIsNull):
+
+2021-02-17 Ruben Turcios <[email protected]>
+
Cherry-pick r270665. rdar://problem/74409412
Removing unnecessary locking from JSValue API functions
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
