Title: [273263] trunk
- Revision
- 273263
- Author
- [email protected]
- Date
- 2021-02-22 10:56:13 -0800 (Mon, 22 Feb 2021)
Log Message
Disable RangeResponseGenerator.
https://bugs.webkit.org/show_bug.cgi?id=221072
<rdar://problem/74551753>
Source/WebCore:
* platform/network/cocoa/RangeResponseGenerator.mm:
(WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
Tools:
It might be causing issues. Disabling to speculatively fix the radar.
* TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::TEST):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (273262 => 273263)
--- trunk/Source/WebCore/ChangeLog 2021-02-22 18:46:50 UTC (rev 273262)
+++ trunk/Source/WebCore/ChangeLog 2021-02-22 18:56:13 UTC (rev 273263)
@@ -1,3 +1,12 @@
+2021-02-22 Alex Christensen <[email protected]>
+
+ Disable RangeResponseGenerator.
+ https://bugs.webkit.org/show_bug.cgi?id=221072
+ <rdar://problem/74551753>
+
+ * platform/network/cocoa/RangeResponseGenerator.mm:
+ (WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
+
2021-02-22 Antti Koivisto <[email protected]>
[LFC][Integration] Respect hasLineIfEmpty
Modified: trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm (273262 => 273263)
--- trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm 2021-02-22 18:46:50 UTC (rev 273262)
+++ trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm 2021-02-22 18:56:13 UTC (rev 273263)
@@ -280,6 +280,10 @@
bool RangeResponseGenerator::willSynthesizeRangeResponses(WebCoreNSURLSessionDataTask *task, PlatformMediaResource& resource, const ResourceResponse& response)
{
+ bool rangeResponseGeneratorDisabled = true;
+ if (rangeResponseGeneratorDisabled)
+ return false;
+
ASSERT(isMainThread());
NSURLRequest *originalRequest = task.originalRequest;
if (!originalRequest.URL)
Modified: trunk/Tools/ChangeLog (273262 => 273263)
--- trunk/Tools/ChangeLog 2021-02-22 18:46:50 UTC (rev 273262)
+++ trunk/Tools/ChangeLog 2021-02-22 18:56:13 UTC (rev 273263)
@@ -1,3 +1,14 @@
+2021-02-22 Alex Christensen <[email protected]>
+
+ Disable RangeResponseGenerator.
+ https://bugs.webkit.org/show_bug.cgi?id=221072
+ <rdar://problem/74551753>
+
+ It might be causing issues. Disabling to speculatively fix the radar.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
+ (TestWebKitAPI::TEST):
+
2021-02-22 Philippe Normand <[email protected]>
[Flatpak SDK] gdb unusable in sandbox
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm (273262 => 273263)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm 2021-02-22 18:46:50 UTC (rev 273262)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm 2021-02-22 18:56:13 UTC (rev 273263)
@@ -152,7 +152,7 @@
{"/", { videoPlayTestHTML }},
{"/video.mp4", { testVideoBytes() }}
});
- runVideoTest(server.request(), "playing");
+ runVideoTest(server.request(), "error");
EXPECT_EQ(server.totalRequests(), 2u);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
