Title: [273287] trunk
Revision
273287
Author
[email protected]
Date
2021-02-22 16:19:02 -0800 (Mon, 22 Feb 2021)

Log Message

Re-enable RangeResponseGenerator.
https://bugs.webkit.org/show_bug.cgi?id=221072
<rdar://problem/74551753>

Source/WebCore:

* platform/network/cocoa/RangeResponseGenerator.mm:
(WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):

Tools:

r273263 was a false alarm.  Reverting that revision.

* TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
(TestWebKitAPI::TEST):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (273286 => 273287)


--- trunk/Source/WebCore/ChangeLog	2021-02-23 00:03:08 UTC (rev 273286)
+++ trunk/Source/WebCore/ChangeLog	2021-02-23 00:19:02 UTC (rev 273287)
@@ -1,3 +1,12 @@
+2021-02-22  Alex Christensen  <[email protected]>
+
+        Re-enable RangeResponseGenerator.
+        https://bugs.webkit.org/show_bug.cgi?id=221072
+        <rdar://problem/74551753>
+
+        * platform/network/cocoa/RangeResponseGenerator.mm:
+        (WebCore::RangeResponseGenerator::willSynthesizeRangeResponses):
+
 2021-02-22  Ada Chan  <[email protected]>
 
         Add a PlatformXR::Device subclass for Cocoa

Modified: trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm (273286 => 273287)


--- trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm	2021-02-23 00:03:08 UTC (rev 273286)
+++ trunk/Source/WebCore/platform/network/cocoa/RangeResponseGenerator.mm	2021-02-23 00:19:02 UTC (rev 273287)
@@ -280,10 +280,6 @@
 
 bool RangeResponseGenerator::willSynthesizeRangeResponses(WebCoreNSURLSessionDataTask *task, PlatformMediaResource& resource, const ResourceResponse& response)
 {
-    bool rangeResponseGeneratorDisabled = true;
-    if (rangeResponseGeneratorDisabled)
-        return false;
-
     ASSERT(isMainThread());
     NSURLRequest *originalRequest = task.originalRequest;
     if (!originalRequest.URL)

Modified: trunk/Tools/ChangeLog (273286 => 273287)


--- trunk/Tools/ChangeLog	2021-02-23 00:03:08 UTC (rev 273286)
+++ trunk/Tools/ChangeLog	2021-02-23 00:19:02 UTC (rev 273287)
@@ -1,3 +1,14 @@
+2021-02-22  Alex Christensen  <[email protected]>
+
+        Re-enable RangeResponseGenerator.
+        https://bugs.webkit.org/show_bug.cgi?id=221072
+        <rdar://problem/74551753>
+
+        r273263 was a false alarm.  Reverting that revision.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm:
+        (TestWebKitAPI::TEST):
+
 2021-02-22  Chris Dumez  <[email protected]>
 
         [Cocoa] Add WKWebView session restoration API

Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm (273286 => 273287)


--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm	2021-02-23 00:03:08 UTC (rev 273286)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/MediaLoading.mm	2021-02-23 00:19:02 UTC (rev 273287)
@@ -152,7 +152,7 @@
         {"/", { videoPlayTestHTML }},
         {"/video.mp4", { testVideoBytes() }}
     });
-    runVideoTest(server.request(), "error");
+    runVideoTest(server.request(), "playing");
     EXPECT_EQ(server.totalRequests(), 2u);
 }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to