Title: [273289] trunk/Source/WebKit
- Revision
- 273289
- Author
- [email protected]
- Date
- 2021-02-22 17:10:56 -0800 (Mon, 22 Feb 2021)
Log Message
UserMediaPermissionRequestManagerProxy may be released while computing capture device list
https://bugs.webkit.org/show_bug.cgi?id=222236
<rdar://74480265>
Unreviewed, address post-review comment.
* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
captured `this`.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (273288 => 273289)
--- trunk/Source/WebKit/ChangeLog 2021-02-23 00:31:56 UTC (rev 273288)
+++ trunk/Source/WebKit/ChangeLog 2021-02-23 01:10:56 UTC (rev 273289)
@@ -1,3 +1,15 @@
+2021-02-22 Eric Carlson <[email protected]>
+
+ UserMediaPermissionRequestManagerProxy may be released while computing capture device list
+ https://bugs.webkit.org/show_bug.cgi?id=222236
+ <rdar://74480265>
+
+ Unreviewed, address post-review comment.
+
+ * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+ (WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList): Use
+ captured `this`.
+
2021-02-22 Chris Dumez <[email protected]>
Prepare for memory ownership transfer in the GPUProcess
Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (273288 => 273289)
--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2021-02-23 00:31:56 UTC (rev 273288)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp 2021-02-23 01:10:56 UTC (rev 273289)
@@ -738,7 +738,7 @@
filteredDevices.append(revealIdsAndLabels ? device : CaptureDevice({ }, device.type(), { }, { }));
}
- weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels;
+ m_hasFilteredDeviceList = !revealIdsAndLabels;
ALWAYS_LOG(LOGIDENTIFIER, filteredDevices.size(), " devices revealed");
completion(WTFMove(filteredDevices));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
