Title: [273304] trunk/Source/WebKit
- Revision
- 273304
- Author
- [email protected]
- Date
- 2021-02-23 05:58:35 -0800 (Tue, 23 Feb 2021)
Log Message
[macOS] Crash under AuxiliaryProcess::initializeSandbox
https://bugs.webkit.org/show_bug.cgi?id=222233
Unreviewed, address additional review feedback.
Add comment and logging when the WebKit client is setting the user directory suffix.
* Shared/mac/AuxiliaryProcessMac.mm:
(WebKit::initializeSandboxParameters):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (273303 => 273304)
--- trunk/Source/WebKit/ChangeLog 2021-02-23 13:01:29 UTC (rev 273303)
+++ trunk/Source/WebKit/ChangeLog 2021-02-23 13:58:35 UTC (rev 273304)
@@ -1,3 +1,15 @@
+2021-02-23 Per Arne Vollan <[email protected]>
+
+ [macOS] Crash under AuxiliaryProcess::initializeSandbox
+ https://bugs.webkit.org/show_bug.cgi?id=222233
+
+ Unreviewed, address additional review feedback.
+
+ Add comment and logging when the WebKit client is setting the user directory suffix.
+
+ * Shared/mac/AuxiliaryProcessMac.mm:
+ (WebKit::initializeSandboxParameters):
+
2021-02-23 Kimmo Kinnunen <[email protected]>
HTMLCanvasElement::copiedImage() contains old image with GPU Process on
Modified: trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm (273303 => 273304)
--- trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm 2021-02-23 13:01:29 UTC (rev 273303)
+++ trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm 2021-02-23 13:58:35 UTC (rev 273304)
@@ -641,9 +641,13 @@
auto userDirectorySuffix = parameters.extraInitializationData.find("user-directory-suffix");
if (userDirectorySuffix != parameters.extraInitializationData.end()) {
String suffix = userDirectorySuffix->value;
+ WTFLogAlways("WebKit client is requesting user directory suffix: %s", suffix.utf8().data());
+ // Make sure the user directory suffix is not a path, since confstr will fail when the path does not exist.
auto firstPathSeparator = suffix.find("/");
- if (firstPathSeparator != notFound)
+ if (firstPathSeparator != notFound) {
suffix.truncate(firstPathSeparator);
+ WTFLogAlways("User directory suffix is a path, which will be truncated: %s", suffix.utf8().data());
+ }
sandboxParameters.setUserDirectorySuffix(suffix);
} else {
String clientIdentifier = codeSigningIdentifier(parameters.connectionIdentifier.xpcConnection.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
