Title: [273320] trunk/Source/WebKit
Revision
273320
Author
[email protected]
Date
2021-02-23 10:55:46 -0800 (Tue, 23 Feb 2021)

Log Message

Unreviewed, reverting r273304.
https://bugs.webkit.org/show_bug.cgi?id=222324

Introduced test failure

Reverted changeset:

"[macOS] Crash under AuxiliaryProcess::initializeSandbox"
https://bugs.webkit.org/show_bug.cgi?id=222233
https://trac.webkit.org/changeset/273304

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (273319 => 273320)


--- trunk/Source/WebKit/ChangeLog	2021-02-23 18:51:41 UTC (rev 273319)
+++ trunk/Source/WebKit/ChangeLog	2021-02-23 18:55:46 UTC (rev 273320)
@@ -1,3 +1,16 @@
+2021-02-23  Commit Queue  <[email protected]>
+
+        Unreviewed, reverting r273304.
+        https://bugs.webkit.org/show_bug.cgi?id=222324
+
+        Introduced test failure
+
+        Reverted changeset:
+
+        "[macOS] Crash under AuxiliaryProcess::initializeSandbox"
+        https://bugs.webkit.org/show_bug.cgi?id=222233
+        https://trac.webkit.org/changeset/273304
+
 2021-02-23  Kimmo Kinnunen  <[email protected]>
 
         REGRESSION(r273204): webkitpy tests fail

Modified: trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm (273319 => 273320)


--- trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm	2021-02-23 18:51:41 UTC (rev 273319)
+++ trunk/Source/WebKit/Shared/mac/AuxiliaryProcessMac.mm	2021-02-23 18:55:46 UTC (rev 273320)
@@ -641,13 +641,9 @@
         auto userDirectorySuffix = parameters.extraInitializationData.find("user-directory-suffix");
         if (userDirectorySuffix != parameters.extraInitializationData.end()) {
             String suffix = userDirectorySuffix->value;
-            WTFLogAlways("WebKit client is requesting user directory suffix: %s", suffix.utf8().data());
-            // Make sure the user directory suffix is not a path, since confstr will fail when the path does not exist.
             auto firstPathSeparator = suffix.find("/");
-            if (firstPathSeparator != notFound) {
+            if (firstPathSeparator != notFound)
                 suffix.truncate(firstPathSeparator);
-                WTFLogAlways("User directory suffix is a path, which will be truncated: %s", suffix.utf8().data());
-            }
             sandboxParameters.setUserDirectorySuffix(suffix);
         } else {
             String clientIdentifier = codeSigningIdentifier(parameters.connectionIdentifier.xpcConnection.get());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to