Title: [273430] trunk/Source/ThirdParty
Revision
273430
Author
timothy_hor...@apple.com
Date
2021-02-24 13:13:25 -0800 (Wed, 24 Feb 2021)

Log Message

Fix linker warnings building gtest for macCatalyst
https://bugs.webkit.org/show_bug.cgi?id=222346
<rdar://problem/74405116>

Reviewed by Alexey Proskuryakov.

* gtest/xcode/Config/FrameworkTarget.xcconfig:
* gtest/xcode/Config/General.xcconfig:
Work around a linker warning about macCatalyst by not specifying
an INSTALL_NAME that is outside of /System/iOSSupport, where all
macCatalyst-only binaries must live.

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ChangeLog (273429 => 273430)


--- trunk/Source/ThirdParty/ChangeLog	2021-02-24 21:00:43 UTC (rev 273429)
+++ trunk/Source/ThirdParty/ChangeLog	2021-02-24 21:13:25 UTC (rev 273430)
@@ -1,3 +1,17 @@
+2021-02-24  Tim Horton  <timothy_hor...@apple.com>
+
+        Fix linker warnings building gtest for macCatalyst
+        https://bugs.webkit.org/show_bug.cgi?id=222346
+        <rdar://problem/74405116>
+
+        Reviewed by Alexey Proskuryakov.
+
+        * gtest/xcode/Config/FrameworkTarget.xcconfig:
+        * gtest/xcode/Config/General.xcconfig:
+        Work around a linker warning about macCatalyst by not specifying
+        an INSTALL_NAME that is outside of /System/iOSSupport, where all
+        macCatalyst-only binaries must live.
+
 2021-01-08  Ryan Hostetler  <rh...@apple.com>
 
         Add support for source caching between platforms

Modified: trunk/Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig (273429 => 273430)


--- trunk/Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig	2021-02-24 21:00:43 UTC (rev 273429)
+++ trunk/Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig	2021-02-24 21:13:25 UTC (rev 273430)
@@ -15,5 +15,3 @@
 
 // Let the user install by specifying the $DSTROOT with xcodebuild
 SKIP_INSTALL = NO
-
-INSTALL_PATH = $(SYSTEM_LIBRARY_DIR)/PrivateFrameworks;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to