Title: [105568] trunk/Source/WebCore
- Revision
- 105568
- Author
- le...@chromium.org
- Date
- 2012-01-20 20:11:08 -0800 (Fri, 20 Jan 2012)
Log Message
Allow isContextThread to be called while in ~ScriptExecutionContext.
https://bugs.webkit.org/show_bug.cgi?id=76756
Reviewed by Adam Barth.
It is possible for objects to get torn down or get called from ~ScriptExecutionContext
and in turn call isContextThread. The resulting behavior is undefined. This change defines
the behavior. I don't know of any places that do this but I have a test that is rarely
failing due to isContextThread being false. This is my best guess as to why, and I
don't see a reason to try to avoid calling isContextThread at this point.
No new functionality exposed so no new tests.
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isContextThread):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105567 => 105568)
--- trunk/Source/WebCore/ChangeLog 2012-01-21 03:32:29 UTC (rev 105567)
+++ trunk/Source/WebCore/ChangeLog 2012-01-21 04:11:08 UTC (rev 105568)
@@ -1,3 +1,21 @@
+2012-01-20 David Levin <le...@chromium.org>
+
+ Allow isContextThread to be called while in ~ScriptExecutionContext.
+ https://bugs.webkit.org/show_bug.cgi?id=76756
+
+ Reviewed by Adam Barth.
+
+ It is possible for objects to get torn down or get called from ~ScriptExecutionContext
+ and in turn call isContextThread. The resulting behavior is undefined. This change defines
+ the behavior. I don't know of any places that do this but I have a test that is rarely
+ failing due to isContextThread being false. This is my best guess as to why, and I
+ don't see a reason to try to avoid calling isContextThread at this point.
+
+ No new functionality exposed so no new tests.
+
+ * dom/ScriptExecutionContext.h:
+ (WebCore::ScriptExecutionContext::isContextThread):
+
2012-01-20 Alexandre Elias <ael...@google.com>
[chromium] Write unit tests for compositor-thread zooming
Modified: trunk/Source/WebCore/dom/ScriptExecutionContext.h (105567 => 105568)
--- trunk/Source/WebCore/dom/ScriptExecutionContext.h 2012-01-21 03:32:29 UTC (rev 105567)
+++ trunk/Source/WebCore/dom/ScriptExecutionContext.h 2012-01-21 04:11:08 UTC (rev 105568)
@@ -80,7 +80,7 @@
// When the database cleanup is done, cleanupSync will be signalled.
void stopDatabases(DatabaseTaskSynchronizer*);
#endif
- virtual bool isContextThread() const = 0;
+ virtual bool isContextThread() const { return true; }
virtual bool isJSExecutionForbidden() const = 0;
const KURL& url() const { return virtualURL(); }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
