Title: [273480] trunk/Source/_javascript_Core
Revision
273480
Author
[email protected]
Date
2021-02-25 01:48:57 -0800 (Thu, 25 Feb 2021)

Log Message

Fix signed vs unsigned comparision warning in JSBigInt
https://bugs.webkit.org/show_bug.cgi?id=222400

Patch by Dmitry Bezhetskov <[email protected]> on 2021-02-25
Reviewed by Yusuke Suzuki.

Fix the warning about comparing uint64_t with int64_t in JSBigInt.

* runtime/JSBigInt.cpp:
(JSC::JSBigInt::parseInt):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (273479 => 273480)


--- trunk/Source/_javascript_Core/ChangeLog	2021-02-25 09:02:56 UTC (rev 273479)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-02-25 09:48:57 UTC (rev 273480)
@@ -1,3 +1,15 @@
+2021-02-25  Dmitry Bezhetskov  <[email protected]>
+
+        Fix signed vs unsigned comparision warning in JSBigInt
+        https://bugs.webkit.org/show_bug.cgi?id=222400
+
+        Reviewed by Yusuke Suzuki.
+
+        Fix the warning about comparing uint64_t with int64_t in JSBigInt.
+
+        * runtime/JSBigInt.cpp:
+        (JSC::JSBigInt::parseInt):
+
 2021-02-24  Alex Christensen  <[email protected]>
 
         Add stubs to enable SafariForWebKitDevelopment to launch

Modified: trunk/Source/_javascript_Core/runtime/JSBigInt.cpp (273479 => 273480)


--- trunk/Source/_javascript_Core/runtime/JSBigInt.cpp	2021-02-25 09:02:56 UTC (rev 273479)
+++ trunk/Source/_javascript_Core/runtime/JSBigInt.cpp	2021-02-25 09:48:57 UTC (rev 273480)
@@ -2527,7 +2527,7 @@
 
         if (!heapResult) {
             if (p == length) {
-                ASSERT(digit.unsafeGet() <= std::numeric_limits<int64_t>::max());
+                ASSERT(digit.unsafeGet() <= static_cast<uint64_t>(std::numeric_limits<int64_t>::max()));
                 int64_t maybeResult = digit.unsafeGet();
                 ASSERT(maybeResult >= 0);
                 if (sign == ParseIntSign::Signed)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to