Title: [273592] trunk
- Revision
- 273592
- Author
- wei...@apple.com
- Date
- 2021-02-26 15:17:07 -0800 (Fri, 26 Feb 2021)
Log Message
Remove non-standard 'css'/'Css' prefixed properties on CSSStyleDeclaration
https://bugs.webkit.org/show_bug.cgi?id=218158
Source/WebCore:
<rdar://problem/70666307>
Reviewed by Tim Horton.
Remove support for 'css'/'Css' prefixed properties of CSSStyleDeclaration which
are no longer supported by any other browser.
* css/CSSStyleDeclaration.cpp:
LayoutTests:
Reviewed by Tim Horton.
* fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt:
* fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:
Update test to reflect removal of css prefixes.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (273591 => 273592)
--- trunk/LayoutTests/ChangeLog 2021-02-26 22:39:58 UTC (rev 273591)
+++ trunk/LayoutTests/ChangeLog 2021-02-26 23:17:07 UTC (rev 273592)
@@ -1,3 +1,14 @@
+2021-02-26 Sam Weinig <wei...@apple.com>
+
+ Remove non-standard 'css'/'Css' prefixed properties on CSSStyleDeclaration
+ https://bugs.webkit.org/show_bug.cgi?id=218158
+
+ Reviewed by Tim Horton.
+
+ * fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt:
+ * fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html:
+ Update test to reflect removal of css prefixes.
+
2021-02-26 Peng Liu <peng.l...@apple.com>
Flaky Test: media/modern-media-controls/tracks-support/tracks-support-show-panel-fullscreen.html
Modified: trunk/LayoutTests/fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt (273591 => 273592)
--- trunk/LayoutTests/fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt 2021-02-26 22:39:58 UTC (rev 273591)
+++ trunk/LayoutTests/fast/dom/CSSStyleDeclaration/css-properties-case-sensitive-expected.txt 2021-02-26 23:17:07 UTC (rev 273592)
@@ -8,13 +8,6 @@
PASS element.style.zIndex is '1'
PASS element.style.ZIndex is undefined.
-"css" prefix
-
-PASS element.style.cssZIndex is '1'
-PASS element.style.CssZIndex is '1'
-PASS element.style.CsszIndex is undefined.
-PASS element.style.csszIndex is undefined.
-
"pixel" prefix
PASS element.style.pixelZIndex is 1
Modified: trunk/LayoutTests/fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html (273591 => 273592)
--- trunk/LayoutTests/fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html 2021-02-26 22:39:58 UTC (rev 273591)
+++ trunk/LayoutTests/fast/dom/CSSStyleDeclaration/css-properties-case-sensitive.html 2021-02-26 23:17:07 UTC (rev 273592)
@@ -19,15 +19,6 @@
shouldBeUndefined("element.style.ZIndex");
debug('');
-debug('"css" prefix');
-debug('');
-
-shouldBe("element.style.cssZIndex", "'1'");
-shouldBe("element.style.CssZIndex", "'1'");
-shouldBeUndefined("element.style.CsszIndex");
-shouldBeUndefined("element.style.csszIndex");
-
-debug('');
debug('"pixel" prefix');
debug('');
Modified: trunk/Source/WebCore/ChangeLog (273591 => 273592)
--- trunk/Source/WebCore/ChangeLog 2021-02-26 22:39:58 UTC (rev 273591)
+++ trunk/Source/WebCore/ChangeLog 2021-02-26 23:17:07 UTC (rev 273592)
@@ -1,3 +1,16 @@
+2021-02-26 Sam Weinig <wei...@apple.com>
+
+ Remove non-standard 'css'/'Css' prefixed properties on CSSStyleDeclaration
+ https://bugs.webkit.org/show_bug.cgi?id=218158
+ <rdar://problem/70666307>
+
+ Reviewed by Tim Horton.
+
+ Remove support for 'css'/'Css' prefixed properties of CSSStyleDeclaration which
+ are no longer supported by any other browser.
+
+ * css/CSSStyleDeclaration.cpp:
+
2021-02-26 Andres Gonzalez <andresg...@apple.com>
Add AXTextMarkerRangeForNSRange attribute so that Mac clients can access this functionality.
Modified: trunk/Source/WebCore/css/CSSStyleDeclaration.cpp (273591 => 273592)
--- trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2021-02-26 22:39:58 UTC (rev 273591)
+++ trunk/Source/WebCore/css/CSSStyleDeclaration.cpp 2021-02-26 23:17:07 UTC (rev 273592)
@@ -46,7 +46,6 @@
enum class PropertyNamePrefix {
None,
Epub,
- CSS,
Pixel,
Pos,
WebKit
@@ -90,10 +89,6 @@
// First character of the prefix within the property name may be upper or lowercase.
UChar firstChar = toASCIILower(propertyName[0]);
switch (firstChar) {
- case 'c':
- if (matchesCSSPropertyNamePrefix(propertyName, "css"))
- return PropertyNamePrefix::CSS;
- break;
case 'e':
if (matchesCSSPropertyNamePrefix(propertyName, "epub"))
return PropertyNamePrefix::Epub;
@@ -167,7 +162,7 @@
const char* name = bufferPtr;
unsigned i = 0;
- // Prefixes CSS, Pixel, Pos are ignored.
+ // Prefixes Pixel and Pos are ignored.
// Prefixes Apple, KHTML and Webkit are transposed to "-webkit-".
// The prefix "Epub" becomes "-epub-".
switch (propertyNamePrefix(*propertyNameString)) {
@@ -175,9 +170,6 @@
if (isASCIIUpper((*propertyNameString)[0]))
return propertyInfo;
break;
- case PropertyNamePrefix::CSS:
- i += 3;
- break;
case PropertyNamePrefix::Pixel:
i += 5;
hadPixelOrPosPrefix = true;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
