Title: [105601] trunk/Tools
Revision
105601
Author
[email protected]
Date
2012-01-23 02:05:29 -0800 (Mon, 23 Jan 2012)

Log Message

[GTK] run-gtk-tests randomly fails while running the xprop comand
https://bugs.webkit.org/show_bug.cgi?id=76817

Reviewed by Philippe Normand.

Temporarily comment the lines related to launching the ATSPI bus
and registry daemon, which are making the bots to fail randomly.

* Scripts/run-gtk-tests:
(TestRunner): Skip TestWebKitAccessibility, as it won't run
properly if the ATSPI infrastructure is not properly initialized.
(TestRunner.run): Comment lines related to initialization of ATSPI.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (105600 => 105601)


--- trunk/Tools/ChangeLog	2012-01-23 10:04:10 UTC (rev 105600)
+++ trunk/Tools/ChangeLog	2012-01-23 10:05:29 UTC (rev 105601)
@@ -1,3 +1,18 @@
+2012-01-23  Mario Sanchez Prada  <[email protected]>
+
+        [GTK] run-gtk-tests randomly fails while running the xprop comand
+        https://bugs.webkit.org/show_bug.cgi?id=76817
+
+        Reviewed by Philippe Normand.
+
+        Temporarily comment the lines related to launching the ATSPI bus
+        and registry daemon, which are making the bots to fail randomly.
+
+        * Scripts/run-gtk-tests:
+        (TestRunner): Skip TestWebKitAccessibility, as it won't run
+        properly if the ATSPI infrastructure is not properly initialized.
+        (TestRunner.run): Comment lines related to initialization of ATSPI.
+
 2012-01-22  Ryosuke Niwa  <[email protected]>
 
         Windows python test build fix.

Modified: trunk/Tools/Scripts/run-gtk-tests (105600 => 105601)


--- trunk/Tools/Scripts/run-gtk-tests	2012-01-23 10:04:10 UTC (rev 105600)
+++ trunk/Tools/Scripts/run-gtk-tests	2012-01-23 10:05:29 UTC (rev 105601)
@@ -25,7 +25,7 @@
 
     TEST_DIRS = [ "unittests", "WebKit2APITests" ]
     # FIXME: https://bugs.webkit.org/show_bug.cgi?id=74717
-    SKIPPED = [ "unittests/testdownload", "unittests/testwebview", "unittests/testwebresource" ]
+    SKIPPED = [ "unittests/testdownload", "unittests/testwebview", "unittests/testwebresource", "WebKit2APITests/TestWebKitAccessibility" ]
 
     def __init__(self):
         self._executive = Executive()
@@ -94,28 +94,38 @@
 
         # Make sure there's no AT_SPI_BUS X's property previously set,
         # otherwise the accessibility bus couldn't be properly launched.
-        self._executive.run_command(['xprop', '-root', '-remove', 'AT_SPI_BUS'], env=test_env)
 
+        # FIXME: Commenting this line while figuring out why this
+        # fails randomly in the GTK bots, making the API tests fail.
+        # https://bugs.webkit.org/show_bug.cgi?id=76817
+        # self._executive.run_command(['xprop', '-root', '-remove', 'AT_SPI_BUS'], env=test_env)
+
         # Make sure the accessibility bus is launched.
         a11y_bus_launched = False
-        a11y_bus_launcher_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi-bus-launcher')
-        if a11y_bus_launcher_path:
-            try:
-                a11y_bus_launcher = Executive().popen([a11y_bus_launcher_path], env=test_env)
-                a11y_bus_launched = True
-            except:
-                sys.stderr.write("Failed to launch the accessibility bus\n")
-                sys.stderr.flush()
+        # FIXME: Commenting the next lines while figuring out why this
+        # fails randomly in the GTK bots, making the API tests fail.
+        # https://bugs.webkit.org/show_bug.cgi?id=76817
+        # a11y_bus_launcher_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi-bus-launcher')
+        # if a11y_bus_launcher_path:
+        #     try:
+        #         a11y_bus_launcher = Executive().popen([a11y_bus_launcher_path], env=test_env)
+        #         a11y_bus_launched = True
+        #     except:
+        #         sys.stderr.write("Failed to launch the accessibility bus\n")
+        #         sys.stderr.flush()
 
         a11y_registryd_running = False
-        a11y_registryd_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi2-registryd')
-        if a11y_registryd_path:
-            try:
-                a11y_registryd = Executive().popen([a11y_registryd_path], env=test_env)
-                a11y_registryd_running = True
-            except:
-                sys.stderr.write("Failed to run the accessibility registry\n")
-                sys.stderr.flush()
+        # FIXME: Commenting the next lines while figuring out why this
+        # fails randomly in the GTK bots, making the API tests fail.
+        # https://bugs.webkit.org/show_bug.cgi?id=76817
+        # a11y_registryd_path = self._lookup_atspi2_binary(jhbuild_path, 'at-spi2-registryd')
+        # if a11y_registryd_path:
+        #     try:
+        #         a11y_registryd = Executive().popen([a11y_registryd_path], env=test_env)
+        #         a11y_registryd_running = True
+        #     except:
+        #         sys.stderr.write("Failed to run the accessibility registry\n")
+        #         sys.stderr.flush()
 
         for test in self._tests:
             out = self._executive.run_command([jhbuild_path ,'gtester', test], env=test_env,
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to