Title: [273768] trunk/Source/_javascript_Core
- Revision
- 273768
- Author
- [email protected]
- Date
- 2021-03-02 16:01:42 -0800 (Tue, 02 Mar 2021)
Log Message
Improve logging of OSR availability analysis validation failures
https://bugs.webkit.org/show_bug.cgi?id=222612
Reviewed by Yusuke Suzuki.
* dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (273767 => 273768)
--- trunk/Source/_javascript_Core/ChangeLog 2021-03-02 23:47:36 UTC (rev 273767)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-03-03 00:01:42 UTC (rev 273768)
@@ -1,3 +1,13 @@
+2021-03-02 Saam Barati <[email protected]>
+
+ Improve logging of OSR availability analysis validation failures
+ https://bugs.webkit.org/show_bug.cgi?id=222612
+
+ Reviewed by Yusuke Suzuki.
+
+ * dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
+ (JSC::DFG::OSRAvailabilityAnalysisPhase::run):
+
2021-03-02 Devin Rousso <[email protected]>
Allow IDL `Date` to be parsed from a string in addition to a number and actual JS `Date`
Modified: trunk/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp (273767 => 273768)
--- trunk/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp 2021-03-02 23:47:36 UTC (rev 273767)
+++ trunk/Source/_javascript_Core/dfg/DFGOSRAvailabilityAnalysisPhase.cpp 2021-03-03 00:01:42 UTC (rev 273768)
@@ -170,8 +170,16 @@
for (size_t i = 0; i < availabilityMap.m_locals.size(); ++i) {
Operand operand = availabilityMap.m_locals.operandForIndex(i);
Availability availability = availabilityMap.m_locals[i];
- if (availability.isDead() && m_graph.isLiveInBytecode(operand, exitOrigin))
+ if (availability.isDead() && m_graph.isLiveInBytecode(operand, exitOrigin)) {
+ for (BasicBlock* block : m_graph.blocksInNaturalOrder()) {
+ dataLogLn("Block #", block->index);
+ dataLogLn("Availability at head: ", availabilityAtHead(block));
+ dataLogLn("Availability at tail: ", availabilityAtTail(block));
+ dataLogLn();
+ }
+
DFG_CRASH(m_graph, node, toCString("Live bytecode local not available: operand = ", operand, ", availabilityMap = ", availabilityMap, ", origin = ", exitOrigin).data());
+ }
}
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
