Title: [273775] trunk/Source/WebKit
- Revision
- 273775
- Author
- [email protected]
- Date
- 2021-03-02 17:12:53 -0800 (Tue, 02 Mar 2021)
Log Message
[ BigSur Debug Wk 2 ] ASSERT NOT REACHED in WebCore::DisplayList::PaintFrameForMedia::apply
https://bugs.webkit.org/show_bug.cgi?id=221989
<rdar://problem/74403030>
Reviewed by Jer Noble.
No new tests, this will fix a crash on debug bots.
* GPUProcess/graphics/RemoteRenderingBackend.cpp:
(WebKit::RemoteRenderingBackend::applyMediaItem): When we cannot get the player, the player
with the given identifier must have been destroyed. This function can return true to indicate
that the item has been applied.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (273774 => 273775)
--- trunk/Source/WebKit/ChangeLog 2021-03-03 00:56:40 UTC (rev 273774)
+++ trunk/Source/WebKit/ChangeLog 2021-03-03 01:12:53 UTC (rev 273775)
@@ -1,3 +1,18 @@
+2021-03-02 Peng Liu <[email protected]>
+
+ [ BigSur Debug Wk 2 ] ASSERT NOT REACHED in WebCore::DisplayList::PaintFrameForMedia::apply
+ https://bugs.webkit.org/show_bug.cgi?id=221989
+ <rdar://problem/74403030>
+
+ Reviewed by Jer Noble.
+
+ No new tests, this will fix a crash on debug bots.
+
+ * GPUProcess/graphics/RemoteRenderingBackend.cpp:
+ (WebKit::RemoteRenderingBackend::applyMediaItem): When we cannot get the player, the player
+ with the given identifier must have been destroyed. This function can return true to indicate
+ that the item has been applied.
+
2021-03-02 Ricky Mondello <[email protected]>
Unconditionally return information in _autofillContext SPI when a field is focused
Modified: trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp (273774 => 273775)
--- trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-03-03 00:56:40 UTC (rev 273774)
+++ trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp 2021-03-03 01:12:53 UTC (rev 273775)
@@ -124,7 +124,7 @@
auto& mediaItem = item.get<DisplayList::PaintFrameForMedia>();
auto player = m_gpuConnectionToWebProcess->remoteMediaPlayerManagerProxy().mediaPlayer(mediaItem.identifier());
if (!player)
- return false;
+ return true;
context.paintFrameForMedia(*player, mediaItem.destination());
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
