Title: [105607] trunk/Source
- Revision
- 105607
- Author
- [email protected]
- Date
- 2012-01-23 03:43:28 -0800 (Mon, 23 Jan 2012)
Log Message
[GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783
Reviewed by Martin Robinson.
Source/WebCore:
Rename WebKitAccessible's public functions to follow WebKit's
coding style and update callers.
* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleNew): Renamed from webkit_accessible_new.
(webkitAccessibleGetAccessibilityObject): Likewise.
(webkitAccessibleDetach):Likewise.
(webkitAccessibleGetFocusedElement): Likewise.
* accessibility/gtk/WebKitAccessibleWrapperAtk.h:
Update calls to WebKitAccessible's public functions.
* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::detachWrapper): Update call.
(WebCore::AXObjectCache::attachWrapper): Ditto.
* accessibility/gtk/WebKitAccessibleHyperlink.cpp:
(core): Update call.
Source/WebKit/gtk:
Update callers to WebKitAccessible's public functions.
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
(modifyAccessibilityValue):
(DumpRenderTreeSupportGtk::accessibilityHelpText):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105606 => 105607)
--- trunk/Source/WebCore/ChangeLog 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebCore/ChangeLog 2012-01-23 11:43:28 UTC (rev 105607)
@@ -1,3 +1,28 @@
+2012-01-23 Mario Sanchez Prada <[email protected]>
+
+ [GTK] Refactor GTK's accessibilitity code to be more modular
+ https://bugs.webkit.org/show_bug.cgi?id=76783
+
+ Reviewed by Martin Robinson.
+
+ Rename WebKitAccessible's public functions to follow WebKit's
+ coding style and update callers.
+
+ * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
+ (webkitAccessibleNew): Renamed from webkit_accessible_new.
+ (webkitAccessibleGetAccessibilityObject): Likewise.
+ (webkitAccessibleDetach):Likewise.
+ (webkitAccessibleGetFocusedElement): Likewise.
+ * accessibility/gtk/WebKitAccessibleWrapperAtk.h:
+
+ Update calls to WebKitAccessible's public functions.
+
+ * accessibility/gtk/AXObjectCacheAtk.cpp:
+ (WebCore::AXObjectCache::detachWrapper): Update call.
+ (WebCore::AXObjectCache::attachWrapper): Ditto.
+ * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
+ (core): Update call.
+
2012-01-19 Kenichi Ishibashi <[email protected]>
WebKit fails IETC composition event types
Modified: trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp (105606 => 105607)
--- trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebCore/accessibility/gtk/AXObjectCacheAtk.cpp 2012-01-23 11:43:28 UTC (rev 105607)
@@ -33,12 +33,12 @@
void AXObjectCache::detachWrapper(AccessibilityObject* obj)
{
- webkit_accessible_detach(WEBKIT_ACCESSIBLE(obj->wrapper()));
+ webkitAccessibleDetach(WEBKIT_ACCESSIBLE(obj->wrapper()));
}
void AXObjectCache::attachWrapper(AccessibilityObject* obj)
{
- AtkObject* atkObj = ATK_OBJECT(webkit_accessible_new(obj));
+ AtkObject* atkObj = ATK_OBJECT(webkitAccessibleNew(obj));
obj->setWrapper(atkObj);
g_object_unref(atkObj);
}
Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp (105606 => 105607)
--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleHyperlink.cpp 2012-01-23 11:43:28 UTC (rev 105607)
@@ -65,7 +65,7 @@
if (!accessible || !WEBKIT_IS_ACCESSIBLE(accessible))
return 0;
- return webkit_accessible_get_accessibility_object(accessible);
+ return webkitAccessibleGetAccessibilityObject(accessible);
}
static AccessibilityObject* core(WebKitAccessibleHyperlink* link)
Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp (105606 => 105607)
--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp 2012-01-23 11:43:28 UTC (rev 105607)
@@ -2680,7 +2680,7 @@
return type;
}
-WebKitAccessible* webkit_accessible_new(AccessibilityObject* coreObject)
+WebKitAccessible* webkitAccessibleNew(AccessibilityObject* coreObject)
{
GType type = getAccessibilityTypeFromObject(coreObject);
AtkObject* object = static_cast<AtkObject*>(g_object_new(type, 0));
@@ -2690,12 +2690,12 @@
return WEBKIT_ACCESSIBLE(object);
}
-AccessibilityObject* webkit_accessible_get_accessibility_object(WebKitAccessible* accessible)
+AccessibilityObject* webkitAccessibleGetAccessibilityObject(WebKitAccessible* accessible)
{
return accessible->m_object;
}
-void webkit_accessible_detach(WebKitAccessible* accessible)
+void webkitAccessibleDetach(WebKitAccessible* accessible)
{
ASSERT(accessible->m_object);
@@ -2708,7 +2708,7 @@
accessible->m_object = fallbackObject();
}
-AtkObject* webkit_accessible_get_focused_element(WebKitAccessible* accessible)
+AtkObject* webkitAccessibleGetFocusedElement(WebKitAccessible* accessible)
{
if (!accessible->m_object)
return 0;
Modified: trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.h (105606 => 105607)
--- trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.h 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.h 2012-01-23 11:43:28 UTC (rev 105607)
@@ -51,13 +51,13 @@
GType webkit_accessible_get_type(void) G_GNUC_CONST;
-WebKitAccessible* webkit_accessible_new(WebCore::AccessibilityObject*);
+WebKitAccessible* webkitAccessibleNew(WebCore::AccessibilityObject*);
-WebCore::AccessibilityObject* webkit_accessible_get_accessibility_object(WebKitAccessible*);
+WebCore::AccessibilityObject* webkitAccessibleGetAccessibilityObject(WebKitAccessible*);
-void webkit_accessible_detach(WebKitAccessible*);
+void webkitAccessibleDetach(WebKitAccessible*);
-AtkObject* webkit_accessible_get_focused_element(WebKitAccessible*);
+AtkObject* webkitAccessibleGetFocusedElement(WebKitAccessible*);
WebCore::AccessibilityObject* objectFocusedAndCaretOffsetUnignored(WebCore::AccessibilityObject*, int& offset);
Modified: trunk/Source/WebKit/gtk/ChangeLog (105606 => 105607)
--- trunk/Source/WebKit/gtk/ChangeLog 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebKit/gtk/ChangeLog 2012-01-23 11:43:28 UTC (rev 105607)
@@ -1,3 +1,17 @@
+2012-01-23 Mario Sanchez Prada <[email protected]>
+
+ [GTK] Refactor GTK's accessibilitity code to be more modular
+ https://bugs.webkit.org/show_bug.cgi?id=76783
+
+ Reviewed by Martin Robinson.
+
+ Update callers to WebKitAccessible's public functions.
+
+ * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
+ (DumpRenderTreeSupportGtk::getFocusedAccessibleElement):
+ (modifyAccessibilityValue):
+ (DumpRenderTreeSupportGtk::accessibilityHelpText):
+
2012-01-22 Mario Sanchez Prada <[email protected]>
[GTK] Refactor GTK's accessibilitity code to be more modular
Modified: trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp (105606 => 105607)
--- trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-01-23 11:17:26 UTC (rev 105606)
+++ trunk/Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp 2012-01-23 11:43:28 UTC (rev 105607)
@@ -484,7 +484,7 @@
if (!wrapper)
return 0;
- return webkit_accessible_get_focused_element(WEBKIT_ACCESSIBLE(wrapper));
+ return webkitAccessibleGetFocusedElement(WEBKIT_ACCESSIBLE(wrapper));
#else
return 0;
#endif
@@ -761,7 +761,7 @@
if (!axObject || !WEBKIT_IS_ACCESSIBLE(axObject))
return;
- AccessibilityObject* coreObject = webkit_accessible_get_accessibility_object(WEBKIT_ACCESSIBLE(axObject));
+ AccessibilityObject* coreObject = webkitAccessibleGetAccessibilityObject(WEBKIT_ACCESSIBLE(axObject));
if (!coreObject)
return;
@@ -786,7 +786,7 @@
if (!axObject || !WEBKIT_IS_ACCESSIBLE(axObject))
return CString();
- AccessibilityObject* coreObject = webkit_accessible_get_accessibility_object(WEBKIT_ACCESSIBLE(axObject));
+ AccessibilityObject* coreObject = webkitAccessibleGetAccessibilityObject(WEBKIT_ACCESSIBLE(axObject));
if (!coreObject)
return CString();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
