Title: [105616] trunk/Tools
Revision
105616
Author
[email protected]
Date
2012-01-23 06:32:41 -0800 (Mon, 23 Jan 2012)

Log Message

[Qt] Don't warn about override and final being C++11 extensions

Clang will emit a warning when these extensions are used without passing
--std=c++11, but we use feature checking to decide if we have the right
extensions, so we can safely ignore these warnings. The XCode and Windows
project files have the same workaround.

The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
we only have one extra compiler for Objective-C, which is also used for
Objective-C++ sources, so we have to pass the flag, even if it doesn't
make sense for Objective-C.

Reviewed by Simon Hausmann.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (105615 => 105616)


--- trunk/Tools/ChangeLog	2012-01-23 14:12:43 UTC (rev 105615)
+++ trunk/Tools/ChangeLog	2012-01-23 14:32:41 UTC (rev 105616)
@@ -1,3 +1,21 @@
+2012-01-23  Tor Arne Vestbø  <[email protected]>
+
+        [Qt] Don't warn about override and final being C++11 extensions
+
+        Clang will emit a warning when these extensions are used without passing
+        --std=c++11, but we use feature checking to decide if we have the right
+        extensions, so we can safely ignore these warnings. The XCode and Windows
+        project files have the same workaround.
+
+        The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
+        we only have one extra compiler for Objective-C, which is also used for
+        Objective-C++ sources, so we have to pass the flag, even if it doesn't
+        make sense for Objective-C.
+
+        Reviewed by Simon Hausmann.
+
+        * qmake/mkspecs/features/unix/default_post.prf:
+
 2012-01-20  Tor Arne Vestbø  <[email protected]>
 
         [Qt] Change how build-webkit decides when to do full incremental builds

Modified: trunk/Tools/qmake/mkspecs/features/unix/default_post.prf (105615 => 105616)


--- trunk/Tools/qmake/mkspecs/features/unix/default_post.prf	2012-01-23 14:12:43 UTC (rev 105615)
+++ trunk/Tools/qmake/mkspecs/features/unix/default_post.prf	2012-01-23 14:32:41 UTC (rev 105616)
@@ -19,6 +19,12 @@
     }
 }
 
+# Don't warn about OVERRIDE and FINAL, since they are feature-checked anyways
+*clang:!contains(QMAKE_CXXFLAGS, -std=c++11) {
+    QMAKE_CXXFLAGS += -Wno-c++11-extensions
+    QMAKE_OBJECTIVE_CFLAGS += -Wno-c++11-extensions
+}
+
 contains(TEMPLATE, app): CONFIG += rpath
 
 load(default_post)
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to