Title: [273963] trunk/Tools
- Revision
- 273963
- Author
- [email protected]
- Date
- 2021-03-05 05:15:25 -0800 (Fri, 05 Mar 2021)
Log Message
[GTK] Clang warnings in MiniBrowser build
https://bugs.webkit.org/show_bug.cgi?id=222797
Patch by Philippe Normand <[email protected]> on 2021-03-05
Reviewed by Carlos Garcia Campos.
Fix unused-value warnings.
* MiniBrowser/gtk/BrowserCellRendererVariant.c:
(browser_cell_renderer_variant_init):
* MiniBrowser/gtk/BrowserTab.c:
(runColorChooserCallback):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (273962 => 273963)
--- trunk/Tools/ChangeLog 2021-03-05 12:16:49 UTC (rev 273962)
+++ trunk/Tools/ChangeLog 2021-03-05 13:15:25 UTC (rev 273963)
@@ -1,3 +1,17 @@
+2021-03-05 Philippe Normand <[email protected]>
+
+ [GTK] Clang warnings in MiniBrowser build
+ https://bugs.webkit.org/show_bug.cgi?id=222797
+
+ Reviewed by Carlos Garcia Campos.
+
+ Fix unused-value warnings.
+
+ * MiniBrowser/gtk/BrowserCellRendererVariant.c:
+ (browser_cell_renderer_variant_init):
+ * MiniBrowser/gtk/BrowserTab.c:
+ (runColorChooserCallback):
+
2021-03-04 Sam Sneddon <[email protected]>
Undeprecate many more webkit-patch commands
Modified: trunk/Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c (273962 => 273963)
--- trunk/Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c 2021-03-05 12:16:49 UTC (rev 273962)
+++ trunk/Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c 2021-03-05 13:15:25 UTC (rev 273963)
@@ -293,13 +293,13 @@
renderer->toggleRenderer = gtk_cell_renderer_toggle_new();
g_object_set(G_OBJECT(renderer->toggleRenderer), "xalign", 0.0, NULL);
- g_object_ref_sink(renderer->toggleRenderer);
+ renderer->toggleRenderer = g_object_ref_sink(renderer->toggleRenderer);
renderer->textRenderer = gtk_cell_renderer_text_new();
g_signal_connect_swapped(renderer->textRenderer, "edited",
G_CALLBACK(browserCellRendererVariantCellRendererTextEdited), renderer);
g_object_set(G_OBJECT(renderer->textRenderer), "editable", TRUE, NULL);
- g_object_ref_sink(renderer->textRenderer);
+ renderer->textRenderer = g_object_ref_sink(renderer->textRenderer);
renderer->spinRenderer = gtk_cell_renderer_spin_new();
g_signal_connect_swapped(renderer->spinRenderer, "edited",
Modified: trunk/Tools/MiniBrowser/gtk/BrowserTab.c (273962 => 273963)
--- trunk/Tools/MiniBrowser/gtk/BrowserTab.c 2021-03-05 12:16:49 UTC (rev 273962)
+++ trunk/Tools/MiniBrowser/gtk/BrowserTab.c 2021-03-05 13:15:25 UTC (rev 273963)
@@ -429,8 +429,7 @@
gtk_widget_show(colorChooser);
#endif
- g_object_ref(request);
- g_signal_connect_object(popover, "hide", G_CALLBACK(popoverColorClosed), request, 0);
+ g_signal_connect_object(popover, "hide", G_CALLBACK(popoverColorClosed), g_object_ref(request), 0);
g_signal_connect_object(request, "finished", G_CALLBACK(colorChooserRequestFinished), popover, 0);
gtk_widget_show(popover);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
