Title: [274151] trunk/Source/WebInspectorUI
- Revision
- 274151
- Author
- [email protected]
- Date
- 2021-03-09 09:35:31 -0800 (Tue, 09 Mar 2021)
Log Message
[Cocoa] Web Inspector: Console search box is broken, advancing to next result instead pastes from system find pasteboard
https://bugs.webkit.org/show_bug.cgi?id=220773
<rdar://problem/73410423>
Reviewed by Devin Rousso.
Ensure FindBanner is always marked as shown in the Console
to prevent malfunction when advancing through search results.
* UserInterface/Views/FindBanner.js:
(WI.FindBanner):
(WI.FindBanner.prototype.set targetElement):
(WI.FindBanner.prototype.hide):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (274150 => 274151)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-03-09 16:55:35 UTC (rev 274150)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-03-09 17:35:31 UTC (rev 274151)
@@ -1,3 +1,19 @@
+2021-03-09 Razvan Caliman <[email protected]>
+
+ [Cocoa] Web Inspector: Console search box is broken, advancing to next result instead pastes from system find pasteboard
+ https://bugs.webkit.org/show_bug.cgi?id=220773
+ <rdar://problem/73410423>
+
+ Reviewed by Devin Rousso.
+
+ Ensure FindBanner is always marked as shown in the Console
+ to prevent malfunction when advancing through search results.
+
+ * UserInterface/Views/FindBanner.js:
+ (WI.FindBanner):
+ (WI.FindBanner.prototype.set targetElement):
+ (WI.FindBanner.prototype.hide):
+
2021-03-08 Patrick Angle <[email protected]>
Web Inspector: REGRESSION (r267038): Inspector fails to show any details about animations/transitions in the timeline
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.js (274150 => 274151)
--- trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.js 2021-03-09 16:55:35 UTC (rev 274150)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FindBanner.js 2021-03-09 17:35:31 UTC (rev 274151)
@@ -25,11 +25,12 @@
WI.FindBanner = class FindBanner extends WI.NavigationItem
{
- constructor(delegate, className, fixed = false)
+ constructor(delegate, className, alwaysShowing = false)
{
super();
this._delegate = delegate || null;
+ this._alwaysShowing = alwaysShowing;
this.element.classList.add("find-banner");
@@ -73,9 +74,10 @@
nextResultButtonGlyphElement.classList.add(WI.FindBanner.SegmentGlyphStyleClassName);
this._nextResultButton.appendChild(nextResultButtonGlyphElement);
- if (fixed)
+ if (this._alwaysShowing) {
+ this.element.classList.add(WI.FindBanner.ShowingStyleClassName);
this._clearAndBlurKeyboardShortcut = new WI.KeyboardShortcut(null, WI.KeyboardShortcut.Key.Escape, this.clearAndBlur.bind(this), this.element);
- else {
+ } else {
let doneButtonElement = document.createElement("button");
doneButtonElement.textContent = WI.UIString("Done");
doneButtonElement.addEventListener("click", this._doneButtonClicked.bind(this));
@@ -138,8 +140,10 @@
this._targetElement.classList.remove(WI.FindBanner.ShowingFindBannerStyleClassName);
this.element.classList.add(WI.FindBanner.NoTransitionStyleClassName);
- this.element.classList.remove(WI.FindBanner.ShowingStyleClassName);
+ if (!this._alwaysShowing)
+ this.element.classList.remove(WI.FindBanner.ShowingStyleClassName);
+
// Delay so we can remove the no transition style class after the other style changes are committed.
setTimeout(delayedWork.bind(this), 0);
}
@@ -214,8 +218,10 @@
this._inputField.blur();
this._targetElement.classList.remove(WI.FindBanner.ShowingFindBannerStyleClassName);
- this.element.classList.remove(WI.FindBanner.ShowingStyleClassName);
+ if (!this._alwaysShowing)
+ this.element.classList.remove(WI.FindBanner.ShowingStyleClassName);
+
this.dispatchEventToListeners(WI.FindBanner.Event.DidHide);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
