Title: [274171] trunk
Revision
274171
Author
[email protected]
Date
2021-03-09 13:19:30 -0800 (Tue, 09 Mar 2021)

Log Message

[GPUP] Enable 2D Canvas in layout tests by default
https://bugs.webkit.org/show_bug.cgi?id=222835

Reviewed by Simon Fraser.

Source/WTF:

Move UseGPUProcessForCanvasRenderingEnabled from WebPreferencesInternal
to WebPreferencesExperimental so that the WebKitTestRunner will turn it
on by default.

* Scripts/Preferences/WebPreferencesExperimental.yaml:
* Scripts/Preferences/WebPreferencesInternal.yaml:

LayoutTests:

Some of the canvas layout tests are still failing when GPUP is enabled
for 2D Canvas. Skip these tests for now.

* TestExpectations:
* gpu-process/TestExpectations:

* http/tests/canvas/color-fonts/fill-gradient-sbix-2.html:
* http/tests/canvas/color-fonts/fill-gradient-sbix-3.html:
* http/tests/canvas/color-fonts/fill-gradient-sbix-4.html:
* http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html:
* http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html:
* http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html:
webkit.org/b/222881

* inspector/canvas/memory.html:
webkit.org/b/222880

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (274170 => 274171)


--- trunk/LayoutTests/ChangeLog	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/ChangeLog	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,27 @@
+2021-03-09  Said Abou-Hallawa  <[email protected]>
+
+        [GPUP] Enable 2D Canvas in layout tests by default
+        https://bugs.webkit.org/show_bug.cgi?id=222835
+
+        Reviewed by Simon Fraser.
+
+        Some of the canvas layout tests are still failing when GPUP is enabled
+        for 2D Canvas. Skip these tests for now.
+
+        * TestExpectations:
+        * gpu-process/TestExpectations:
+
+        * http/tests/canvas/color-fonts/fill-gradient-sbix-2.html:
+        * http/tests/canvas/color-fonts/fill-gradient-sbix-3.html:
+        * http/tests/canvas/color-fonts/fill-gradient-sbix-4.html:
+        * http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html:
+        * http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html:
+        * http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html:
+        webkit.org/b/222881
+
+        * inspector/canvas/memory.html:
+        webkit.org/b/222880
+
 2021-03-09  Antti Koivisto  <[email protected]>
 
         REGRESSION (r273003): Animated style may lose original display property value

Modified: trunk/LayoutTests/TestExpectations (274170 => 274171)


--- trunk/LayoutTests/TestExpectations	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/TestExpectations	2021-03-09 21:19:30 UTC (rev 274171)
@@ -4083,6 +4083,7 @@
 imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height-orientation-none.tentative.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height.tentative.html [ ImageOnlyFailure ]
 imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element.tentative.html [ ImageOnlyFailure ]
+imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
 
 # Sometimes prints weird output at the beginning of the tests.
 imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas [ Failure Pass ]

Modified: trunk/LayoutTests/gpu-process/TestExpectations (274170 => 274171)


--- trunk/LayoutTests/gpu-process/TestExpectations	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/gpu-process/TestExpectations	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,7 +1,3 @@
-# webkit.org/b/222728
-imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
-inspector/canvas/memory.html [ Failure ]
-
 # webkit.org/b/222726
 fast/canvas/webgl/uniform-samplers-test.html [ Slow ]
 webgl/1.0.3/conformance/uniforms/uniform-samplers-test.html [ Slow ]

Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html (274170 => 274171)


--- trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html (274170 => 274171)


--- trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html (274170 => 274171)


--- trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html (274170 => 274171)


--- trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html (274170 => 274171)


--- trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html (274170 => 274171)


--- trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/LayoutTests/inspector/canvas/memory.html (274170 => 274171)


--- trunk/LayoutTests/inspector/canvas/memory.html	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/LayoutTests/inspector/canvas/memory.html	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
 <!DOCTYPE html>
 <html>
 <head>

Modified: trunk/Source/WTF/ChangeLog (274170 => 274171)


--- trunk/Source/WTF/ChangeLog	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/Source/WTF/ChangeLog	2021-03-09 21:19:30 UTC (rev 274171)
@@ -1,3 +1,17 @@
+2021-03-09  Said Abou-Hallawa  <[email protected]>
+
+        [GPUP] Enable 2D Canvas in layout tests by default
+        https://bugs.webkit.org/show_bug.cgi?id=222835
+
+        Reviewed by Simon Fraser.
+
+        Move UseGPUProcessForCanvasRenderingEnabled from WebPreferencesInternal 
+        to WebPreferencesExperimental so that the WebKitTestRunner will turn it
+        on by default.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+        * Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2021-03-09  Sam Weinig  <[email protected]>
 
         Remove CSSParserContext::enforcesCSSMIMETypeInNoQuirksMode as it is unused

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (274170 => 274171)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-03-09 21:19:30 UTC (rev 274171)
@@ -922,6 +922,17 @@
     WebKit:
       default: true
 
+UseGPUProcessForCanvasRenderingEnabled:
+  type: bool
+  humanReadableName: "GPU Process: Canvas Rendering"
+  humanReadableDescription: "Enable canvas rendering in GPU Process"
+  webcoreBinding: none
+  condition: ENABLE(GPU_PROCESS)
+  exposed: [ WebKit ]
+  defaultValue:
+    WebKit:
+      default: defaultUseGPUProcessForCanvasRenderingEnabled()
+
 UseGPUProcessForMediaEnabled:
   type: bool
   humanReadableName: "GPU Process: Media"

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (274170 => 274171)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-03-09 21:17:43 UTC (rev 274170)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-03-09 21:19:30 UTC (rev 274171)
@@ -764,17 +764,6 @@
     WebKit:
       default: true
 
-UseGPUProcessForCanvasRenderingEnabled:
-  type: bool
-  humanReadableName: "GPU Process: Canvas Rendering"
-  humanReadableDescription: "Enable canvas rendering in GPU Process"
-  webcoreBinding: none
-  condition: ENABLE(GPU_PROCESS)
-  exposed: [ WebKit ]
-  defaultValue:
-    WebKit:
-      default: defaultUseGPUProcessForCanvasRenderingEnabled()
-
 UseGPUProcessForDOMRenderingEnabled:
   type: bool
   humanReadableName: "GPU Process: DOM Rendering"
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to