Diff
Modified: trunk/LayoutTests/ChangeLog (274183 => 274184)
--- trunk/LayoutTests/ChangeLog 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/ChangeLog 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,3 +1,16 @@
+2021-03-09 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r274171.
+ https://bugs.webkit.org/show_bug.cgi?id=223004
+
+ Broke canvas layout tests on Apple Silicon
+
+ Reverted changeset:
+
+ "[GPUP] Enable 2D Canvas in layout tests by default"
+ https://bugs.webkit.org/show_bug.cgi?id=222835
+ https://trac.webkit.org/changeset/274171
+
2021-03-09 Ryan Haddad <[email protected]>
[Big Sur arm64] WebGL texture-copying-feedback-loops tests crashing in com.apple.AppleMetalOpenGLRenderer GLDContextRec::finishResource
Modified: trunk/LayoutTests/TestExpectations (274183 => 274184)
--- trunk/LayoutTests/TestExpectations 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/TestExpectations 2021-03-09 23:51:50 UTC (rev 274184)
@@ -4083,7 +4083,6 @@
imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height-orientation-none.tentative.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element-swap-width-height.tentative.html [ ImageOnlyFailure ]
imported/w3c/web-platform-tests/html/canvas/element/drawing-images-to-the-canvas/image-orientation/drawImage-from-element.tentative.html [ ImageOnlyFailure ]
-imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
# Sometimes prints weird output at the beginning of the tests.
imported/w3c/web-platform-tests/html/canvas/element/wide-gamut-canvas [ Failure Pass ]
Modified: trunk/LayoutTests/gpu-process/TestExpectations (274183 => 274184)
--- trunk/LayoutTests/gpu-process/TestExpectations 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/gpu-process/TestExpectations 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,3 +1,7 @@
+# webkit.org/b/222728
+imported/w3c/web-platform-tests/html/canvas/element/path-objects/2d.path.stroke.scale2.html [ Failure ]
+inspector/canvas/memory.html [ Failure ]
+
# webkit.org/b/222726
fast/canvas/webgl/uniform-samplers-test.html [ Slow ]
webgl/1.0.3/conformance/uniforms/uniform-samplers-test.html [ Slow ]
Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html (274183 => 274184)
--- trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-2.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html (274183 => 274184)
--- trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-3.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html (274183 => 274184)
--- trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/fill-gradient-sbix-4.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html (274183 => 274184)
--- trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-2.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html (274183 => 274184)
--- trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-3.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html (274183 => 274184)
--- trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/http/tests/canvas/color-fonts/stroke-gradient-sbix-4.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/LayoutTests/inspector/canvas/memory.html (274183 => 274184)
--- trunk/LayoutTests/inspector/canvas/memory.html 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/LayoutTests/inspector/canvas/memory.html 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,4 +1,3 @@
-<!-- webkit-test-runner [ UseGPUProcessForCanvasRenderingEnabled=false ] -->
<!DOCTYPE html>
<html>
<head>
Modified: trunk/Source/WTF/ChangeLog (274183 => 274184)
--- trunk/Source/WTF/ChangeLog 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/Source/WTF/ChangeLog 2021-03-09 23:51:50 UTC (rev 274184)
@@ -1,3 +1,16 @@
+2021-03-09 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r274171.
+ https://bugs.webkit.org/show_bug.cgi?id=223004
+
+ Broke canvas layout tests on Apple Silicon
+
+ Reverted changeset:
+
+ "[GPUP] Enable 2D Canvas in layout tests by default"
+ https://bugs.webkit.org/show_bug.cgi?id=222835
+ https://trac.webkit.org/changeset/274171
+
2021-03-09 Chris Dumez <[email protected]>
Stop using callOnMainThread() / isMainThread() in WebKit2
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (274183 => 274184)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-03-09 23:51:50 UTC (rev 274184)
@@ -922,17 +922,6 @@
WebKit:
default: true
-UseGPUProcessForCanvasRenderingEnabled:
- type: bool
- humanReadableName: "GPU Process: Canvas Rendering"
- humanReadableDescription: "Enable canvas rendering in GPU Process"
- webcoreBinding: none
- condition: ENABLE(GPU_PROCESS)
- exposed: [ WebKit ]
- defaultValue:
- WebKit:
- default: defaultUseGPUProcessForCanvasRenderingEnabled()
-
UseGPUProcessForMediaEnabled:
type: bool
humanReadableName: "GPU Process: Media"
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (274183 => 274184)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-03-09 23:50:16 UTC (rev 274183)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml 2021-03-09 23:51:50 UTC (rev 274184)
@@ -764,6 +764,17 @@
WebKit:
default: true
+UseGPUProcessForCanvasRenderingEnabled:
+ type: bool
+ humanReadableName: "GPU Process: Canvas Rendering"
+ humanReadableDescription: "Enable canvas rendering in GPU Process"
+ webcoreBinding: none
+ condition: ENABLE(GPU_PROCESS)
+ exposed: [ WebKit ]
+ defaultValue:
+ WebKit:
+ default: defaultUseGPUProcessForCanvasRenderingEnabled()
+
UseGPUProcessForDOMRenderingEnabled:
type: bool
humanReadableName: "GPU Process: DOM Rendering"
