Diff
Modified: trunk/ChangeLog (274207 => 274208)
--- trunk/ChangeLog 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/ChangeLog 2021-03-10 11:56:00 UTC (rev 274208)
@@ -1,3 +1,16 @@
+2021-03-10 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r274166.
+ https://bugs.webkit.org/show_bug.cgi?id=223024
+
+ Broke GTK Debug builds
+
+ Reverted changeset:
+
+ "[GTK] Reenable -fvisibility=hidden"
+ https://bugs.webkit.org/show_bug.cgi?id=181916
+ https://trac.webkit.org/changeset/274166
+
2021-03-09 Don Olmstead <[email protected]>
GLib JSC API headers should only include other GLib JSC API headers
Modified: trunk/Source/WebCore/ChangeLog (274207 => 274208)
--- trunk/Source/WebCore/ChangeLog 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Source/WebCore/ChangeLog 2021-03-10 11:56:00 UTC (rev 274208)
@@ -1,3 +1,16 @@
+2021-03-10 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r274166.
+ https://bugs.webkit.org/show_bug.cgi?id=223024
+
+ Broke GTK Debug builds
+
+ Reverted changeset:
+
+ "[GTK] Reenable -fvisibility=hidden"
+ https://bugs.webkit.org/show_bug.cgi?id=181916
+ https://trac.webkit.org/changeset/274166
+
2021-03-10 Youenn Fablet <[email protected]>
Make RTCDataChannel use a ScriptExecutionContext instead of a Document
Modified: trunk/Source/WebCore/PlatformGTK.cmake (274207 => 274208)
--- trunk/Source/WebCore/PlatformGTK.cmake 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Source/WebCore/PlatformGTK.cmake 2021-03-10 11:56:00 UTC (rev 274208)
@@ -8,6 +8,13 @@
set(WebCore_OUTPUT_NAME WebCoreGTK)
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=181916
+# Remove these lines when turning on hidden visibility
+list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::WTF)
+if (NOT USE_SYSTEM_MALLOC)
+ list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::bmalloc)
+endif ()
+
list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES
"SourcesGTK.txt"
Modified: trunk/Source/WebCore/dom/EventTarget.cpp (274207 => 274208)
--- trunk/Source/WebCore/dom/EventTarget.cpp 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Source/WebCore/dom/EventTarget.cpp 2021-03-10 11:56:00 UTC (rev 274208)
@@ -66,8 +66,6 @@
return EventTargetConcrete::create(context);
}
-EventTarget::~EventTarget() = default;
-
bool EventTarget::isNode() const
{
return false;
Modified: trunk/Source/WebCore/dom/EventTarget.h (274207 => 274208)
--- trunk/Source/WebCore/dom/EventTarget.h 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Source/WebCore/dom/EventTarget.h 2021-03-10 11:56:00 UTC (rev 274208)
@@ -103,7 +103,7 @@
const EventTargetData* eventTargetData() const;
protected:
- WEBCORE_EXPORT virtual ~EventTarget();
+ virtual ~EventTarget() = default;
virtual EventTargetData* eventTargetData() = 0;
virtual EventTargetData* eventTargetDataConcurrently() = 0;
Modified: trunk/Source/cmake/OptionsGTK.cmake (274207 => 274208)
--- trunk/Source/cmake/OptionsGTK.cmake 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Source/cmake/OptionsGTK.cmake 2021-03-10 11:56:00 UTC (rev 274208)
@@ -18,11 +18,6 @@
CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(_javascript_CORE 37 0 19)
-set(CMAKE_C_VISIBILITY_PRESET hidden)
-set(CMAKE_CXX_VISIBILITY_PRESET hidden)
-set(bmalloc_LIBRARY_TYPE OBJECT)
-set(WTF_LIBRARY_TYPE OBJECT)
-
# These are shared variables, but we special case their definition so that we can use the
# CMAKE_INSTALL_* variables that are populated by the GNUInstallDirs macro.
set(LIB_INSTALL_DIR "${CMAKE_INSTALL_FULL_LIBDIR}" CACHE PATH "Absolute path to library installation directory")
Modified: trunk/Tools/ChangeLog (274207 => 274208)
--- trunk/Tools/ChangeLog 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Tools/ChangeLog 2021-03-10 11:56:00 UTC (rev 274208)
@@ -1,3 +1,16 @@
+2021-03-10 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r274166.
+ https://bugs.webkit.org/show_bug.cgi?id=223024
+
+ Broke GTK Debug builds
+
+ Reverted changeset:
+
+ "[GTK] Reenable -fvisibility=hidden"
+ https://bugs.webkit.org/show_bug.cgi?id=181916
+ https://trac.webkit.org/changeset/274166
+
2021-03-09 Don Olmstead <[email protected]>
GLib JSC API headers should only include other GLib JSC API headers
Modified: trunk/Tools/TestWebKitAPI/PlatformGTK.cmake (274207 => 274208)
--- trunk/Tools/TestWebKitAPI/PlatformGTK.cmake 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Tools/TestWebKitAPI/PlatformGTK.cmake 2021-03-10 11:56:00 UTC (rev 274208)
@@ -28,6 +28,9 @@
GTK::GTK
)
+# FIXME: Remove when turning on hidden visibility https://bugs.webkit.org/show_bug.cgi?id=181916
+list(APPEND TestJavaScriptCore_LIBRARIES WTF)
+
# TestWebCore
list(APPEND TestWebCore_SOURCES
${test_main_SOURCES}
Modified: trunk/Tools/TestWebKitAPI/glib/TestExpectations.json (274207 => 274208)
--- trunk/Tools/TestWebKitAPI/glib/TestExpectations.json 2021-03-10 11:54:03 UTC (rev 274207)
+++ trunk/Tools/TestWebKitAPI/glib/TestExpectations.json 2021-03-10 11:56:00 UTC (rev 274208)
@@ -294,9 +294,6 @@
"subtests": {
"/jsc/vm": {
"expected": {"all": {"slow": true}}
- },
- "/jsc/weak-value": {
- "expected": {"all": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/222972"}}
}
}
},
