Title: [274229] trunk/Source/WebInspectorUI
- Revision
- 274229
- Author
- [email protected]
- Date
- 2021-03-10 12:36:30 -0800 (Wed, 10 Mar 2021)
Log Message
Web Inspector: CSS Grid Inspector clean-up
https://bugs.webkit.org/show_bug.cgi?id=222913
<rdar://problem/75171301>
Reviewed by BJ Burg.
Remove obsolete methods to show/hide the grid overlay directly from a DOMNode.
Remove engineering-only context menu helpers used while implementing grid overlays.
* UserInterface/Models/DOMNode.js:
* UserInterface/Views/ContextMenuUtilities.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (274228 => 274229)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-03-10 20:09:30 UTC (rev 274228)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-03-10 20:36:30 UTC (rev 274229)
@@ -1,3 +1,17 @@
+2021-03-10 Razvan Caliman <[email protected]>
+
+ Web Inspector: CSS Grid Inspector clean-up
+ https://bugs.webkit.org/show_bug.cgi?id=222913
+ <rdar://problem/75171301>
+
+ Reviewed by BJ Burg.
+
+ Remove obsolete methods to show/hide the grid overlay directly from a DOMNode.
+ Remove engineering-only context menu helpers used while implementing grid overlays.
+
+ * UserInterface/Models/DOMNode.js:
+ * UserInterface/Views/ContextMenuUtilities.js:
+
2021-03-09 Razvan Caliman <[email protected]>
Web Inspector: Jump from Layout panel to grid container element
Modified: trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js (274228 => 274229)
--- trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js 2021-03-10 20:09:30 UTC (rev 274228)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js 2021-03-10 20:36:30 UTC (rev 274229)
@@ -574,34 +574,6 @@
target.DOMAgent.highlightNode(WI.DOMManager.buildHighlightConfig(mode), this.id);
}
- showGridOverlay(color, {showLineNames, showLineNumbers, showExtendedGridLines, showTrackSizes, showAreaNames} = {})
- {
- console.assert(color instanceof WI.Color, color);
-
- if (this._destroyed)
- return Promise.reject("Cannot show overlay, node is destroyed");
-
- let target = WI.assumingMainTarget();
- return target.DOMAgent.showGridOverlay.invoke({
- nodeId: this.id,
- gridColor: color.toProtocol(),
- showLineNames: !!showLineNames,
- showLineNumbers: !!showLineNumbers,
- showExtendedGridLines: !!showExtendedGridLines,
- showTrackSizes: !!showTrackSizes,
- showAreaNames: !!showAreaNames,
- });
- }
-
- hideGridOverlay()
- {
- if (this._destroyed)
- return Promise.reject("Cannot hide overlay, node is destroyed");
-
- let target = WI.assumingMainTarget();
- return target.DOMAgent.hideGridOverlay(this.id);
- }
-
scrollIntoView()
{
WI.RemoteObject.resolveNode(this).then((object) => {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (274228 => 274229)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2021-03-10 20:09:30 UTC (rev 274228)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2021-03-10 20:36:30 UTC (rev 274229)
@@ -386,28 +386,6 @@
}
contextMenu.appendSeparator();
-
- // FIXME: <https://webkit.org/b/221246> remove these engineering-only menu items when removing the feature flag.
- if (WI.isEngineeringBuild && WI.settings.experimentalEnableLayoutPanel.value) {
- if (InspectorBackend.hasCommand("DOM.showGridOverlay") && attached) {
- contextMenu.appendItem(WI.unlocalizedString("Add Grid Overlay with Random Color"), () => {
- let randomComponent = () => Math.floor(Math.random() * 255);
- let color = new WI.Color(WI.Color.Format.RGB, [randomComponent(), randomComponent(), randomComponent()]);
- domNode.showGridOverlay(color).catch(console.error);
- });
-
- contextMenu.appendItem(WI.unlocalizedString("Remove Grid Overlay for this Node"), () => {
- domNode.hideGridOverlay();
- });
-
- contextMenu.appendItem(WI.unlocalizedString("Remove All Grid Overlays"), () => {
- let target = WI.assumingMainTarget();
- target.DOMAgent.hideGridOverlay();
- });
- }
- }
-
- contextMenu.appendSeparator();
}
};
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
