Title: [274233] trunk/Tools
Revision
274233
Author
[email protected]
Date
2021-03-10 13:20:41 -0800 (Wed, 10 Mar 2021)

Log Message

[WPE][GTK] Running Tools/gtk/install-dependencies installs too many packages on Debian/Ubuntu
https://bugs.webkit.org/show_bug.cgi?id=223036

Reviewed by Don Olmstead.

Avoid installing unneeded packages by passing --no-install-recommends to apt-get
invocations. While at it, also make sure to always pass -y to make the installation
non-interactive.

* gtk/install-dependencies:
* wpe/install-dependencies:

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (274232 => 274233)


--- trunk/Tools/ChangeLog	2021-03-10 21:16:59 UTC (rev 274232)
+++ trunk/Tools/ChangeLog	2021-03-10 21:20:41 UTC (rev 274233)
@@ -1,3 +1,17 @@
+2021-03-10  Adrian Perez de Castro  <[email protected]>
+
+        [WPE][GTK] Running Tools/gtk/install-dependencies installs too many packages on Debian/Ubuntu
+        https://bugs.webkit.org/show_bug.cgi?id=223036
+
+        Reviewed by Don Olmstead.
+
+        Avoid installing unneeded packages by passing --no-install-recommends to apt-get
+        invocations. While at it, also make sure to always pass -y to make the installation
+        non-interactive.
+
+        * gtk/install-dependencies:
+        * wpe/install-dependencies:
+
 2021-03-10  Brent Fulgham  <[email protected]>
 
         [Cocoa] Add additional bundle ID property to WKWebViewConfiguration

Modified: trunk/Tools/gtk/install-dependencies (274232 => 274233)


--- trunk/Tools/gtk/install-dependencies	2021-03-10 21:16:59 UTC (rev 274232)
+++ trunk/Tools/gtk/install-dependencies	2021-03-10 21:20:41 UTC (rev 274233)
@@ -259,13 +259,13 @@
         gstreamer1.0-plugins-ugly \
         gstreamer1.0-pulseaudio"
 
-    apt-get install $packages
+    apt-get install -y --no-install-recommends $packages
 
     # Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path.
     if apt-cache show pipenv &>/dev/null; then
-        apt-get install pipenv
+        apt-get install -y --no-install-recommends pipenv
     else
-        apt-get install -y python3-pip
+        apt-get install -y --no-install-recommends python3-pip
         pip3 install pipenv
     fi
 }

Modified: trunk/Tools/wpe/install-dependencies (274232 => 274233)


--- trunk/Tools/wpe/install-dependencies	2021-03-10 21:16:59 UTC (rev 274232)
+++ trunk/Tools/wpe/install-dependencies	2021-03-10 21:20:41 UTC (rev 274233)
@@ -162,13 +162,13 @@
         gstreamer1.0-plugins-ugly \
         gstreamer1.0-pulseaudio"
 
-    apt-get install $packages
+    apt-get install -y --no-install-recommends $packages
 
     # Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path.
     if apt-cache show pipenv &>/dev/null; then
-        apt-get install pipenv
+        apt-get install -y --no-install-recommends pipenv
     else
-        apt-get install -y python3-pip
+        apt-get install -y --no-install-recommends python3-pip
         pip3 install pipenv
     fi
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to