Title: [105652] trunk/Tools
- Revision
- 105652
- Author
- [email protected]
- Date
- 2012-01-23 16:01:23 -0800 (Mon, 23 Jan 2012)
Log Message
check-webkit-style whitespace/operators triggers on overloaded division operator
https://bugs.webkit.org/show_bug.cgi?id=76650
Reviewed by Darin Adler.
* Scripts/webkitpy/style/checkers/cpp.py:
(check_spacing):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTest.test_operator_methods):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (105651 => 105652)
--- trunk/Tools/ChangeLog 2012-01-24 00:00:55 UTC (rev 105651)
+++ trunk/Tools/ChangeLog 2012-01-24 00:01:23 UTC (rev 105652)
@@ -1,3 +1,15 @@
+2012-01-23 Emil A Eklund <[email protected]>
+
+ check-webkit-style whitespace/operators triggers on overloaded division operator
+ https://bugs.webkit.org/show_bug.cgi?id=76650
+
+ Reviewed by Darin Adler.
+
+ * Scripts/webkitpy/style/checkers/cpp.py:
+ (check_spacing):
+ * Scripts/webkitpy/style/checkers/cpp_unittest.py:
+ (CppStyleTest.test_operator_methods):
+
2012-01-23 Ryosuke Niwa <[email protected]>
run-perf-tests should report server-side errors
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py (105651 => 105652)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2012-01-24 00:00:55 UTC (rev 105651)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp.py 2012-01-24 00:01:23 UTC (rev 105652)
@@ -1808,7 +1808,7 @@
line = clean_lines.elided[line_number] # get rid of comments and strings
# Don't try to do spacing checks for operator methods
- line = sub(r'operator(==|!=|<|<<|<=|>=|>>|>|\+=|-=|\*=|/=|%=|&=|\|=|^=|<<=|>>=)\(', 'operator\(', line)
+ line = sub(r'operator(==|!=|<|<<|<=|>=|>>|>|\+=|-=|\*=|/=|%=|&=|\|=|^=|<<=|>>=|/)\(', 'operator\(', line)
# Don't try to do spacing checks for #include or #import statements at
# minimum because it messes up checks for spacing around /
if match(r'\s*#\s*(?:include|import)', line):
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py (105651 => 105652)
--- trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-01-24 00:00:55 UTC (rev 105651)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py 2012-01-24 00:01:23 UTC (rev 105652)
@@ -1715,6 +1715,7 @@
def test_operator_methods(self):
self.assert_lint('String operator+(const String&, const String&);', '')
+ self.assert_lint('String operator/(const String&, const String&);', '')
self.assert_lint('bool operator==(const String&, const String&);', '')
self.assert_lint('String& operator-=(const String&, const String&);', '')
self.assert_lint('String& operator+=(const String&, const String&);', '')
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
