Title: [274466] trunk/Source/WebInspectorUI
- Revision
- 274466
- Author
- nvasil...@apple.com
- Date
- 2021-03-15 22:55:19 -0700 (Mon, 15 Mar 2021)
Log Message
Web Inspector: remove experimental setting and enable Layout sidebar
https://bugs.webkit.org/show_bug.cgi?id=221246
<rdar://problem/74130753>
Reviewed by BJ Burg.
* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Base/Setting.js:
* UserInterface/Views/ElementsTabContentView.js:
(WI.ElementsTabContentView):
* UserInterface/Views/SettingsTabContentView.js:
(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (274465 => 274466)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-03-16 05:08:03 UTC (rev 274465)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-03-16 05:55:19 UTC (rev 274466)
@@ -1,3 +1,18 @@
+2021-03-15 Nikita Vasilyev <nvasil...@apple.com>
+
+ Web Inspector: remove experimental setting and enable Layout sidebar
+ https://bugs.webkit.org/show_bug.cgi?id=221246
+ <rdar://problem/74130753>
+
+ Reviewed by BJ Burg.
+
+ * Localizations/en.lproj/localizedStrings.js:
+ * UserInterface/Base/Setting.js:
+ * UserInterface/Views/ElementsTabContentView.js:
+ (WI.ElementsTabContentView):
+ * UserInterface/Views/SettingsTabContentView.js:
+ (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
2021-03-15 Patrick Angle <pan...@apple.com>
Web Inspector: `Styles` sidebar pseudo-class checkboxes appear cramped after resizing window at narrow widths
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (274465 => 274466)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-03-16 05:08:03 UTC (rev 274465)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2021-03-16 05:55:19 UTC (rev 274466)
@@ -1316,7 +1316,6 @@
localizedStrings["Show Console"] = "Show Console";
localizedStrings["Show Console tab"] = "Show Console tab";
localizedStrings["Show Elements"] = "Show Elements";
-localizedStrings["Show Layout panel"] = "Show Layout panel";
localizedStrings["Show Path"] = "Show Path";
localizedStrings["Show Remaining (%d)"] = "Show Remaining (%d)";
localizedStrings["Show Scope Chain on pause"] = "Show Scope Chain on pause";
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js (274465 => 274466)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-03-16 05:08:03 UTC (rev 274465)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js 2021-03-16 05:55:19 UTC (rev 274466)
@@ -228,7 +228,6 @@
experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", true),
experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
- experimentalEnableLayoutPanel: new WI.Setting("experimental-enable-layout-panel", false),
experimentalEnableGridBadges: new WI.Setting("experimental-enable-grid-badges", false),
experimentalCollapseBlackboxedCallFrames: new WI.Setting("experimental-collapse-blackboxed-call-frames", false),
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js (274465 => 274466)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2021-03-16 05:08:03 UTC (rev 274465)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js 2021-03-16 05:55:19 UTC (rev 274466)
@@ -32,7 +32,8 @@
WI.ComputedStyleDetailsSidebarPanel,
];
- if (WI.settings.experimentalEnableLayoutPanel.value)
+ // COMPATIBILITY (iOS 14.5): `DOM.showGridOverlay` did not exist yet.
+ if (InspectorBackend.hasCommand("DOM.showGridOverlay"))
detailsSidebarPanelConstructors.push(WI.LayoutDetailsSidebarPanel);
// COMPATIBILITY (iOS 14.0): `CSS.getFontDataForNode` did not exist yet.
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (274465 => 274466)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-03-16 05:08:03 UTC (rev 274465)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js 2021-03-16 05:55:19 UTC (rev 274466)
@@ -398,7 +398,6 @@
let stylesGroup = experimentalSettingsView.addGroup(WI.UIString("Styles:"));
stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToEffective, WI.UIString("Show jump to effective property button"));
stylesGroup.addSetting(WI.settings.experimentalEnableStylesJumpToVariableDeclaration, WI.UIString("Show jump to variable declaration button"));
- stylesGroup.addSetting(WI.settings.experimentalEnableLayoutPanel, WI.UIString("Show Layout panel"));
stylesGroup.addSetting(WI.settings.experimentalEnableGridBadges, WI.unlocalizedString("Show \"grid\" badges"));
experimentalSettingsView.addSeparator();
@@ -429,7 +428,6 @@
listenForChange(WI.settings.experimentalEnablePreviewFeatures);
if (hasCSSDomain) {
- listenForChange(WI.settings.experimentalEnableLayoutPanel);
listenForChange(WI.settings.experimentalEnableGridBadges);
listenForChange(WI.settings.experimentalEnableStylesJumpToEffective);
listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
