Title: [274490] trunk/Source/WebKit
- Revision
- 274490
- Author
- [email protected]
- Date
- 2021-03-16 10:33:55 -0700 (Tue, 16 Mar 2021)
Log Message
Add internal additions for WebAuthn compatibility
https://bugs.webkit.org/show_bug.cgi?id=223168
<rdar://problem/74890060>
Reviewed by Brent Fulgham.
* UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
(shouldUseAlternateQuery):
(alternateQueryForRPID):
(WebKit::LocalAuthenticatorInternal::getExistingCredentials):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (274489 => 274490)
--- trunk/Source/WebKit/ChangeLog 2021-03-16 17:30:06 UTC (rev 274489)
+++ trunk/Source/WebKit/ChangeLog 2021-03-16 17:33:55 UTC (rev 274490)
@@ -1,3 +1,16 @@
+2021-03-16 Kate Cheney <[email protected]>
+
+ Add internal additions for WebAuthn compatibility
+ https://bugs.webkit.org/show_bug.cgi?id=223168
+ <rdar://problem/74890060>
+
+ Reviewed by Brent Fulgham.
+
+ * UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:
+ (shouldUseAlternateQuery):
+ (alternateQueryForRPID):
+ (WebKit::LocalAuthenticatorInternal::getExistingCredentials):
+
2021-03-16 Peng Liu <[email protected]>
[iOS] Scroll event is fired before webkitfullscreenchange event when an element enters fullscreen
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm (274489 => 274490)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2021-03-16 17:30:06 UTC (rev 274489)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm 2021-03-16 17:33:55 UTC (rev 274490)
@@ -47,6 +47,17 @@
#import <wtf/text/Base64.h>
#import <wtf/text/StringHash.h>
+#if USE(APPLE_INTERNAL_SDK)
+#import <WebKitAdditions/LocalAuthenticatorAdditions.h>
+#else
+static bool shouldUseAlternateQuery() { return false; }
+static NSDictionary *alternateQueryForRPID(const String&)
+{
+ ASSERT_NOT_REACHED();
+ return nil;
+}
+#endif
+
namespace WebKit {
using namespace fido;
using namespace WebCore;
@@ -130,6 +141,10 @@
(id)kSecAttrNoLegacy: @YES
#endif
};
+
+ if (shouldUseAlternateQuery())
+ query = alternateQueryForRPID(rpId);
+
CFTypeRef attributesArrayRef = nullptr;
OSStatus status = SecItemCopyMatching((__bridge CFDictionaryRef)query, &attributesArrayRef);
if (status && status != errSecItemNotFound)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
