Title: [274618] trunk/Source/WebKit
- Revision
- 274618
- Author
- [email protected]
- Date
- 2021-03-18 00:21:13 -0700 (Thu, 18 Mar 2021)
Log Message
[iOS] Web process sometimes crashes under WebPage::positionInformation() after r274031
https://bugs.webkit.org/show_bug.cgi?id=223417
<rdar://problem/75540178>
Reviewed by Devin Rousso.
Add a null check to guard against the case where the hit-tested node is null, but the element responding to
click events exists.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::elementPositionInformation):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (274617 => 274618)
--- trunk/Source/WebKit/ChangeLog 2021-03-18 06:06:13 UTC (rev 274617)
+++ trunk/Source/WebKit/ChangeLog 2021-03-18 07:21:13 UTC (rev 274618)
@@ -1,3 +1,17 @@
+2021-03-18 Wenson Hsieh <[email protected]>
+
+ [iOS] Web process sometimes crashes under WebPage::positionInformation() after r274031
+ https://bugs.webkit.org/show_bug.cgi?id=223417
+ <rdar://problem/75540178>
+
+ Reviewed by Devin Rousso.
+
+ Add a null check to guard against the case where the hit-tested node is null, but the element responding to
+ click events exists.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::elementPositionInformation):
+
2021-03-17 Peng Liu <[email protected]>
[GPUP] WebGL2RenderingContext::texImage2D() does not work with a video as the image source
Modified: trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (274617 => 274618)
--- trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2021-03-18 06:06:13 UTC (rev 274617)
+++ trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm 2021-03-18 07:21:13 UTC (rev 274618)
@@ -2741,7 +2741,7 @@
if (auto* renderer = element.renderer()) {
bool shouldCollectImagePositionInformation = renderer->isRenderImage();
#if ENABLE(IMAGE_EXTRACTION)
- if (HTMLElement::isImageOverlayText(*innerNonSharedNode))
+ if (innerNonSharedNode && HTMLElement::isImageOverlayText(*innerNonSharedNode))
shouldCollectImagePositionInformation = false;
#else
UNUSED_PARAM(innerNonSharedNode);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
