Title: [274666] trunk/Source/WebCore
- Revision
- 274666
- Author
- [email protected]
- Date
- 2021-03-18 12:47:24 -0700 (Thu, 18 Mar 2021)
Log Message
[GTK] Kinetic iframe async scrolling does not work
https://bugs.webkit.org/show_bug.cgi?id=223133
Patch by Alejandro G. Castro <[email protected]> on 2021-03-18
Reviewed by Carlos Garcia Campos.
Add a condition for the gtk port, it allows end of momentum wheel
events to be detected as a scrollable events, no matter of the
delta value. By definition of the API delta is going to be zero in
gtk end of momentum events according to:
https://developer.gnome.org/gdk3/stable/gdk3-Events.html#gdk-event-is-scroll-stop-event
* page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (274665 => 274666)
--- trunk/Source/WebCore/ChangeLog 2021-03-18 19:45:10 UTC (rev 274665)
+++ trunk/Source/WebCore/ChangeLog 2021-03-18 19:47:24 UTC (rev 274666)
@@ -1,3 +1,19 @@
+2021-03-18 Alejandro G. Castro <[email protected]>
+
+ [GTK] Kinetic iframe async scrolling does not work
+ https://bugs.webkit.org/show_bug.cgi?id=223133
+
+ Reviewed by Carlos Garcia Campos.
+
+ Add a condition for the gtk port, it allows end of momentum wheel
+ events to be detected as a scrollable events, no matter of the
+ delta value. By definition of the API delta is going to be zero in
+ gtk end of momentum events according to:
+ https://developer.gnome.org/gdk3/stable/gdk3-Events.html#gdk-event-is-scroll-stop-event
+
+ * page/scrolling/ScrollingTreeScrollingNode.cpp:
+ (WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):
+
2021-03-18 Chris Dumez <[email protected]>
Avoid heap allocations under BiquadDSPKernel::updateCoefficientsIfNecessary()
Modified: trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp (274665 => 274666)
--- trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp 2021-03-18 19:45:10 UTC (rev 274665)
+++ trunk/Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp 2021-03-18 19:47:24 UTC (rev 274666)
@@ -167,6 +167,14 @@
bool ScrollingTreeScrollingNode::eventCanScrollContents(const PlatformWheelEvent& wheelEvent) const
{
+#if PLATFORM(GTK)
+ // In case of GTK platform the end of momentum scroll events
+ // always have a delta of 0. More information in the documentation
+ // of the API gdk_event_is_scroll_stop_event.
+ if (wheelEvent.isEndOfNonMomentumScroll())
+ return true;
+#endif
+
if (wheelEvent.delta().isZero())
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
