Title: [274687] trunk/Source/WebCore
- Revision
- 274687
- Author
- [email protected]
- Date
- 2021-03-18 16:40:54 -0700 (Thu, 18 Mar 2021)
Log Message
Unreviewed, reverting r274669.
https://bugs.webkit.org/show_bug.cgi?id=223487
Broke two debug layout tests
Reverted changeset:
"CSP headers can block default <video> controls"
https://bugs.webkit.org/show_bug.cgi?id=223422
https://trac.webkit.org/changeset/274669
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (274686 => 274687)
--- trunk/Source/WebCore/ChangeLog 2021-03-18 23:39:04 UTC (rev 274686)
+++ trunk/Source/WebCore/ChangeLog 2021-03-18 23:40:54 UTC (rev 274687)
@@ -1,3 +1,16 @@
+2021-03-18 Commit Queue <[email protected]>
+
+ Unreviewed, reverting r274669.
+ https://bugs.webkit.org/show_bug.cgi?id=223487
+
+ Broke two debug layout tests
+
+ Reverted changeset:
+
+ "CSP headers can block default <video> controls"
+ https://bugs.webkit.org/show_bug.cgi?id=223422
+ https://trac.webkit.org/changeset/274669
+
2021-03-18 Chris Dumez <[email protected]>
Avoid heap allocation under AudioParamTimeline::processSetTargetFollowedByRamp()
Modified: trunk/Source/WebCore/Modules/modern-media-controls/controls/icon-service.js (274686 => 274687)
--- trunk/Source/WebCore/Modules/modern-media-controls/controls/icon-service.js 2021-03-18 23:39:04 UTC (rev 274686)
+++ trunk/Source/WebCore/Modules/modern-media-controls/controls/icon-service.js 2021-03-18 23:40:54 UTC (rev 274687)
@@ -82,20 +82,11 @@
image = this.images[path] = new Image;
- // Prevent this image from being shown if it's ever attached to the DOM.
- image.style.display = "none";
-
- // Must attach the `<img>` to the UA shadow root before setting `src` so that `isInUserAgentShadowTree` is correct.
- this.shadowRoot?.appendChild(image);
-
if (this.mediaControlsHost)
image.src = "" icon.type)}`;
else
image.src = ""
- // Remove the `<img>` from the shadow root once the `src` has been set as `isInUserAgentShadowTree` has already been checked by this point.
- image.remove();
-
return image;
}
Modified: trunk/Source/WebCore/Modules/modern-media-controls/main.js (274686 => 274687)
--- trunk/Source/WebCore/Modules/modern-media-controls/main.js 2021-03-18 23:39:04 UTC (rev 274686)
+++ trunk/Source/WebCore/Modules/modern-media-controls/main.js 2021-03-18 23:40:54 UTC (rev 274687)
@@ -34,10 +34,7 @@
{
if (host) {
mediaControlsHost = host;
-
- iconService.shadowRoot = shadowRoot;
iconService.mediaControlsHost = host;
-
shadowRoot.appendChild(document.createElement("style")).textContent = host.shadowRootCSSText;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
