Title: [274714] trunk/Source/WebKitLegacy
Revision
274714
Author
[email protected]
Date
2021-03-19 06:58:03 -0700 (Fri, 19 Mar 2021)

Log Message

[Win] Fix build issue
https://bugs.webkit.org/show_bug.cgi?id=223451
<rdar://75545172>

Reviewed by Brent Fulgham.

Source/WebKitLegacy:

Specify that WebKitLegacy links WebCore and PAL statically, since the correctness of the WEBCORE_EXPORT macro depends on that.

* PlatformWin.cmake:

Source/WebKitLegacy/win:

Add WebCore namespace to function call.

* Plugins/PluginView.cpp:
(WebCore::PluginView::getValueForURL):

Modified Paths

Diff

Modified: trunk/Source/WebKitLegacy/ChangeLog (274713 => 274714)


--- trunk/Source/WebKitLegacy/ChangeLog	2021-03-19 13:26:08 UTC (rev 274713)
+++ trunk/Source/WebKitLegacy/ChangeLog	2021-03-19 13:58:03 UTC (rev 274714)
@@ -1,3 +1,15 @@
+2021-03-19  Per Arne  <[email protected]>
+
+        [Win] Fix build issue
+        https://bugs.webkit.org/show_bug.cgi?id=223451
+        <rdar://75545172>
+
+        Reviewed by Brent Fulgham.
+
+        Specify that WebKitLegacy links WebCore and PAL statically, since the correctness of the WEBCORE_EXPORT macro depends on that.
+
+        * PlatformWin.cmake:
+
 2021-03-11  Chris Dumez  <[email protected]>
 
         Introduce ensureOnMainThread()

Modified: trunk/Source/WebKitLegacy/PlatformWin.cmake (274713 => 274714)


--- trunk/Source/WebKitLegacy/PlatformWin.cmake	2021-03-19 13:26:08 UTC (rev 274713)
+++ trunk/Source/WebKitLegacy/PlatformWin.cmake	2021-03-19 13:58:03 UTC (rev 274714)
@@ -522,3 +522,8 @@
 set(WebKitLegacy_OUTPUT_NAME
     WebKit${DEBUG_SUFFIX}
 )
+
+list(APPEND WebKitLegacy_PRIVATE_DEFINITIONS
+    STATICALLY_LINKED_WITH_PAL
+    STATICALLY_LINKED_WITH_WebCore
+)

Modified: trunk/Source/WebKitLegacy/win/ChangeLog (274713 => 274714)


--- trunk/Source/WebKitLegacy/win/ChangeLog	2021-03-19 13:26:08 UTC (rev 274713)
+++ trunk/Source/WebKitLegacy/win/ChangeLog	2021-03-19 13:58:03 UTC (rev 274714)
@@ -1,3 +1,16 @@
+2021-03-19  Per Arne  <[email protected]>
+
+        [Win] Fix build issue
+        https://bugs.webkit.org/show_bug.cgi?id=223451
+        <rdar://75545172>
+
+        Reviewed by Brent Fulgham.
+
+        Add WebCore namespace to function call.
+
+        * Plugins/PluginView.cpp:
+        (WebCore::PluginView::getValueForURL):
+
 2021-03-14  Fujii Hironori  <[email protected]>
 
         [Win][WK1] Add a new API IWebPreferences::startBatchingUpdates to defer WebPreferencesChangedNotification

Modified: trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp (274713 => 274714)


--- trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp	2021-03-19 13:26:08 UTC (rev 274713)
+++ trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp	2021-03-19 13:58:03 UTC (rev 274714)
@@ -1295,7 +1295,7 @@
     case NPNURLVProxy: {
         URL u(m_parentFrame->document()->baseURL(), url);
         if (u.isValid()) {
-            const CString proxyStr = toString(proxyServersForURL(u)).utf8();
+            const CString proxyStr = toString(WebCore::proxyServersForURL(u)).utf8();
             if (!proxyStr.isNull()) {
                 const int size = proxyStr.length();
                 *value = static_cast<char*>(NPN_MemAlloc(size+1));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to