Title: [274744] trunk/Tools
Revision
274744
Author
[email protected]
Date
2021-03-19 15:44:42 -0700 (Fri, 19 Mar 2021)

Log Message

Update filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=223528

Reviewed by Simon Fraser.

- Remove a bunch of informational messages that clog up output.
- Remove some linker/loader warnings that are non-actionable.
- Generalize a few existing filters to work with more targets.
- Remove super-noisy and meaningless device preparation warnings.

* Scripts/filter-build-webkit:
(shouldIgnoreLine):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (274743 => 274744)


--- trunk/Tools/ChangeLog	2021-03-19 22:32:30 UTC (rev 274743)
+++ trunk/Tools/ChangeLog	2021-03-19 22:44:42 UTC (rev 274744)
@@ -1,3 +1,18 @@
+2021-03-19  BJ Burg  <[email protected]>
+
+        Update filter-build-webkit
+        https://bugs.webkit.org/show_bug.cgi?id=223528
+
+        Reviewed by Simon Fraser.
+
+        - Remove a bunch of informational messages that clog up output.
+        - Remove some linker/loader warnings that are non-actionable.
+        - Generalize a few existing filters to work with more targets.
+        - Remove super-noisy and meaningless device preparation warnings.
+
+        * Scripts/filter-build-webkit:
+        (shouldIgnoreLine):
+
 2021-03-19  Kimmo Kinnunen  <[email protected]>
 
         update-webgl-conformance-tests script should use webgl/1.0.x and webgl/2.0.y directories

Modified: trunk/Tools/Scripts/filter-build-webkit (274743 => 274744)


--- trunk/Tools/Scripts/filter-build-webkit	2021-03-19 22:32:30 UTC (rev 274743)
+++ trunk/Tools/Scripts/filter-build-webkit	2021-03-19 22:44:42 UTC (rev 274744)
@@ -83,6 +83,7 @@
 our $unfilteredOutputPath = "build.log";
 our $useColor = -t STDOUT;
 our $inEntitlements = 0;
+our $inDevicePreparationWarnings = 0;
 
 sub usageAndExit()
 {
@@ -147,7 +148,7 @@
         printLine($line, STYLE_PLAIN);
     } elsif ($line =~ /\*\* BUILD SUCCEEDED \*\*/) {
         printLine("Build Succeeded", STYLE_SUCCESS);
-    } elsif ($line =~ /^(\e\[1m)?(PhaseScriptExecution|RuleScriptExecution|ClCompile|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Preprocess|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|AnalyzeShallow|ProcessProductPackaging|CodeSign|Validate|SymLink|Updating|CompileDTraceScript|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile|GenerateTAPI|CompileStoryboard|ExternalBuildToolExecution|CreateBuildDirectory|WriteAuxiliaryFile|RegisterWithLaunchServices|RegisterExecutionPolicyException|MkDir|Strip|MetalLink|CompileMetalFile)(\e\[0m)? ("[^"]+"|(\\|(?<=\\)\s|\S)+)?/) {
+    } elsif ($line =~ /^(\e\[1m)?(PhaseScriptExecution|RuleScriptExecution|ClCompile|CompileC|Distributed-CompileC|Ld|PBXCp|CpResource|CopyPNGFile|CopyTiffFile|CpHeader|Preprocess|Processing|ProcessInfoPlistFile|ProcessPCH|ProcessPCH\+\+|Touch|Libtool|CopyStringsFile|Mig|CreateUniversalBinary|Analyze|AnalyzeShallow|ProcessProductPackaging|CodeSign|Validate|SymLink|Updating|CompileDTraceScript|CompileXIB|StripNIB|CopyPlistFile|GenerateDSYMFile|GenerateTAPI|CompileStoryboard|ExternalBuildToolExecution|CreateBuildDirectory|WriteAuxiliaryFile|RegisterWithLaunchServices|RegisterExecutionPolicyException|MkDir|Strip|MetalLink|CompileMetalFile|ValidateEmbeddedBinary)(\e\[0m)? ("[^"]+"|(\\|(?<=\\)\s|\S)+)?/) {
         my ($command, $path) = ($2, basename($4));
         $path =~ s/("|\\|\.[ah]$)//g;
         printLine("$command $path", STYLE_PLAIN);
@@ -300,6 +301,17 @@
         return 1
     }
 
+    # iPhone preparation errors always start and end with lines containing 'iPhoneConnect:'.
+    if ($inDevicePreparationWarnings) {
+        $inDevicePreparationWarnings = 0 if $line =~ /== END: Underlying device preparation warnings ==/;
+        return 1
+    }
+
+    if ($line =~ /iPhoneConnect:/) {
+        $inDevicePreparationWarnings = 1;
+        return 1
+    }
+
     return 1 if $line =~ /^\s*$/;
     return 1 if $line =~ /^Command line invocation:/;
     return 1 if $line =~ /^Build settings from command line:/;
@@ -313,7 +325,7 @@
     return 1 if $line =~ /^note: Using eager compilation/;
     return 1 if $line =~ /^note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 "Operation not permitted"/;
     return 1 if $line =~ /^note: detected encoding of input file as Unicode \(.*\)/;
-    return 1 if $line =~ /make(\[\d+\])?: Nothing to be done for `all'\./;
+    return 1 if $line =~ /make(\[\d+\])?: Nothing to be done for/;
     return 1 if $line =~ /^_javascript_Core\/create_hash_table/;
     return 1 if $line =~ /_javascript_Core.framework\/PrivateHeaders\/create_hash_table/;
     return 1 if $line =~ /^_javascript_Core\/pcre\/dftables/;
@@ -333,10 +345,12 @@
     return 1 if $line =~ /One of the two will be used\. Which one is undefined\./;
     return 1 if $line =~ /The Legacy Build System will be removed in a future release/;
     return 1 if $line =~ /^\( (xcodebuild|if) /;
+    return 1 if $line =~ /^warning: can't find additional SDK/;
+    return 1 if $line =~ /^warning: no umbrella header found for target '.*', module map will not be generated$/;
     return 1 if $line =~ /^warning\: detected internal install, passing entitlements to simulator anyway\./;
     return 1 if $line =~ /may not function in the Simulator because Ad Hoc/;
     return 1 if $line =~ /\/usr\/bin\/clang .*? \> \S+.sb/;
-    return 1 if $line =~ / xcodebuild\[[0-9]+:[0-9a-f]+\]\s+DVTAssertions: Warning in .*XCClangResultsPostprocessor.m/;
+    return 1 if $line =~ / xcodebuild\[[0-9]+:[0-9a-f]+\]\s+DVTAssertions: Warning in .*/;
     return 1 if $line =~ /^(Details|Object|Method|Function|Thread):/;
     return 1 if $line =~ /^Please file a bug at /;
     return 1 if $line =~ /created by an unsupported XCDependencyGraph build$/;
@@ -344,8 +358,20 @@
     return 1 if $line =~ /.* com.apple.actool.compilation-results .*/;
     return 1 if $line =~ /.*\/Assets.car/;
     return 1 if $line =~ /.*\/assetcatalog_generated_info.plist/;
+    return 1 if $line =~ /^mount: .+ failed with/;
+    return 1 if $line =~ /^Using .+ production environment.$/;
+    return 1 if $line =~ /replacing existing signature$/;
+    return 1 if $line =~ /^Unlocking '.*\.keychain-db'$/;
+    return 1 if $line =~ /^\d+ localizable strings$/;
+    return 1 if $line =~ /^\d+ plural rules$/;
+    return 1 if $line =~ /^The list of exported symbols did not change.$/;
+    return 1 if $line =~ /^ditto: Cannot get the real path for source/;
+    return 1 if $line =~ /^Duplicate Entry Was Skipped:/;
+    return 1 if $line =~ /^Adding .*?entitlements/;
+    return 1 if $line =~ /^Making app bundle launchable/;
+    return 1 if $line =~ /^Finished adding entitlements\.$/;
+    return 1 if $line =~ /^.* will not be code signed because its settings don't specify a development team.$/;
 
-
     if ($platform eq "win") {
         return 1 if $line =~ /^\s*(touch|perl|cat|rm -f|del|python|\/usr\/bin\/g\+\+|gperf|echo|sed|if \[ \-f|WebCore\/generate-export-file) /;
         return 1 if $line =~ /^\s*(if not exist \"|if errorlevel 1)/;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to