Title: [274766] trunk/Source/WebKit
Revision
274766
Author
[email protected]
Date
2021-03-22 11:47:35 -0700 (Mon, 22 Mar 2021)

Log Message

Add an early return in UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList
https://bugs.webkit.org/show_bug.cgi?id=223571

Reviewed by Eric Carlson.

Update code to early return as soon as possible.

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (274765 => 274766)


--- trunk/Source/WebKit/ChangeLog	2021-03-22 18:46:57 UTC (rev 274765)
+++ trunk/Source/WebKit/ChangeLog	2021-03-22 18:47:35 UTC (rev 274766)
@@ -1,3 +1,15 @@
+2021-03-22  Youenn Fablet  <[email protected]>
+
+        Add an early return in UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList
+        https://bugs.webkit.org/show_bug.cgi?id=223571
+
+        Reviewed by Eric Carlson.
+
+        Update code to early return as soon as possible.
+
+        * UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
+        (WebKit::UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList):
+
 2021-03-19  Darin Adler  <[email protected]>
 
         [Cocoa] Make it possible to release a WKWebView on a non-main thread without a crash due to WKScriptMessage race

Modified: trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp (274765 => 274766)


--- trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2021-03-22 18:46:57 UTC (rev 274765)
+++ trunk/Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp	2021-03-22 18:47:35 UTC (rev 274766)
@@ -738,8 +738,10 @@
 
     platformGetMediaStreamDevices([this, weakThis = makeWeakPtr(this), revealIdsAndLabels, completion = WTFMove(completion)](auto&& devices) mutable {
 
-        if (!weakThis)
+        if (!weakThis) {
             completion({ });
+            return;
+        }
 
         unsigned cameraCount = 0;
         unsigned microphoneCount = 0;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to