Title: [274798] trunk/Source/ThirdParty/ANGLE
Revision
274798
Author
[email protected]
Date
2021-03-22 14:21:48 -0700 (Mon, 22 Mar 2021)

Log Message

Metal-Angle on Simulator does not support D24S8 correctly
https://bugs.webkit.org/show_bug.cgi?id=223494

Patch by Kyle Piddington <[email protected]> on 2021-03-19
Reviewed by Dean Jackson.

Re-ran autogen script for format table to add the missing format
Corrected texture swizzle support. Swizzle is unsupported on simulator.

* src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:
(rx::mtl::Format::init):

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (274797 => 274798)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-03-22 21:11:28 UTC (rev 274797)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-03-22 21:21:48 UTC (rev 274798)
@@ -1,3 +1,16 @@
+2021-03-19  Kyle Piddington  <[email protected]>
+
+        Metal-Angle on Simulator does not support D24S8 correctly
+        https://bugs.webkit.org/show_bug.cgi?id=223494
+
+        Reviewed by Dean Jackson.
+
+        Re-ran autogen script for format table to add the missing format
+        Corrected texture swizzle support. Swizzle is unsupported on simulator.
+
+        * src/libANGLE/renderer/metal/mtl_format_table_autogen.mm:
+        (rx::mtl::Format::init):
+
 2021-03-19  Alex Christensen  <[email protected]>
 
         libANGLE-shared.dylib needs INSTALL_PATH when building Catalyst roots

Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm (274797 => 274798)


--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm	2021-03-22 21:11:28 UTC (rev 274797)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm	2021-03-22 21:21:48 UTC (rev 274798)
@@ -832,7 +832,7 @@
                             isMetal2_1 && !isIntel() && !isNVIDIA());
 
     ANGLE_FEATURE_CONDITION((&mFeatures), hasTextureSwizzle,
-                            isMetal2_2 && supportsEitherGPUFamily(1, 2));
+                            isMetal2_2 && supportsEitherGPUFamily(3, 2) && !isSimulator);
 
     // http://crbug.com/1136673
     // Fence sync is flaky on Nvidia

Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm (274797 => 274798)


--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm	2021-03-22 21:11:28 UTC (rev 274797)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/mtl_format_table_autogen.mm	2021-03-22 21:21:48 UTC (rev 274798)
@@ -1356,6 +1356,15 @@
             this->swizzled = false;
             break;
 
+        case angle::FormatID::D24_UNORM_S8_UINT:
+            
+            this->metalFormat = MTLPixelFormatDepth32Float_Stencil8;
+            this->actualFormatId = angle::FormatID::D32_FLOAT_S8X24_UINT;
+            this->initFunction = nullptr;
+
+            this->swizzled = false;
+            break;
+
         case angle::FormatID::R4G4B4A4_UNORM:
             
             this->metalFormat = MTLPixelFormatRGBA8Unorm;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to