Title: [274855] trunk/Source/WebKit
- Revision
- 274855
- Author
- [email protected]
- Date
- 2021-03-23 02:15:24 -0700 (Tue, 23 Mar 2021)
Log Message
Enable webrtc GPU Process feature flag
https://bugs.webkit.org/show_bug.cgi?id=223582
Reviewed by Eric Carlson.
Enable WebRTC GPU process feature flag.
Make use of it for WebRTC codecs experimental flag default value.
Make use of it for WebRTC video capture experimental flag default value on iOS. Keep it to false on MacOS.
Update audio capture experimental flag default value to false on MacOS until we can use the feature flag value.
No change of behavior.
* FeatureFlags/WebKit-appletvos.plist:
* FeatureFlags/WebKit-ios.plist:
* FeatureFlags/WebKit-macos.plist:
* FeatureFlags/WebKit-watchos.plist:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
(WebKit::defaultCaptureVideoInGPUProcessEnabled):
(WebKit::defaultWebRTCCodecsInGPUProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (274854 => 274855)
--- trunk/Source/WebKit/ChangeLog 2021-03-23 08:56:32 UTC (rev 274854)
+++ trunk/Source/WebKit/ChangeLog 2021-03-23 09:15:24 UTC (rev 274855)
@@ -1,3 +1,25 @@
+2021-03-23 Youenn Fablet <[email protected]>
+
+ Enable webrtc GPU Process feature flag
+ https://bugs.webkit.org/show_bug.cgi?id=223582
+
+ Reviewed by Eric Carlson.
+
+ Enable WebRTC GPU process feature flag.
+ Make use of it for WebRTC codecs experimental flag default value.
+ Make use of it for WebRTC video capture experimental flag default value on iOS. Keep it to false on MacOS.
+ Update audio capture experimental flag default value to false on MacOS until we can use the feature flag value.
+ No change of behavior.
+
+ * FeatureFlags/WebKit-appletvos.plist:
+ * FeatureFlags/WebKit-ios.plist:
+ * FeatureFlags/WebKit-macos.plist:
+ * FeatureFlags/WebKit-watchos.plist:
+ * Shared/WebPreferencesDefaultValues.cpp:
+ (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+ (WebKit::defaultCaptureVideoInGPUProcessEnabled):
+ (WebKit::defaultWebRTCCodecsInGPUProcess):
+
2021-03-22 Myles C. Maxfield <[email protected]>
[GPU Process]: Improve getImageData() perf part 1: Add a GetImageData display list item
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (274854 => 274855)
--- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2021-03-23 08:56:32 UTC (rev 274854)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist 2021-03-23 09:15:24 UTC (rev 274855)
@@ -2,90 +2,90 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
- <key>app_highlights</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>async_frame_and_overflow_scrolling</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>gpu_process_canvas_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_dom_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_media</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webgl</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webrtc</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>InAppBrowserPrivacy</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <key>app_highlights</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>async_frame_and_overflow_scrolling</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>gpu_process_canvas_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_dom_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_media</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webgl</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webrtc</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>InAppBrowserPrivacy</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>incremental_pdf</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
<key>sw_vp9_decoder_on_battery</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
<key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>WebGL2</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebGPU</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebXR</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>RB_full_manage_WK_jetsam</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>WebGL2</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebGPU</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebXR</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>webm_format_reader</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>webm_parser</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>RB_full_manage_WK_jetsam</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (274854 => 274855)
--- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2021-03-23 08:56:32 UTC (rev 274854)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist 2021-03-23 09:15:24 UTC (rev 274855)
@@ -2,90 +2,90 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
- <key>app_highlights</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>async_frame_and_overflow_scrolling</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>gpu_process_canvas_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_dom_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_media</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webgl</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webrtc</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>InAppBrowserPrivacy</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <key>app_highlights</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>async_frame_and_overflow_scrolling</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>gpu_process_canvas_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_dom_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_media</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webgl</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webrtc</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>InAppBrowserPrivacy</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>incremental_pdf</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
<key>sw_vp9_decoder_on_battery</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
<key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>WebGL2</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebGPU</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebXR</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>RB_full_manage_WK_jetsam</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>WebGL2</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebGPU</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebXR</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>webm_format_reader</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>webm_parser</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>RB_full_manage_WK_jetsam</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist (274854 => 274855)
--- trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2021-03-23 08:56:32 UTC (rev 274854)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist 2021-03-23 09:15:24 UTC (rev 274855)
@@ -2,90 +2,90 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
- <key>app_highlights</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>async_frame_and_overflow_scrolling</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>gpu_process_canvas_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_dom_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_media</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webgl</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webrtc</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>InAppBrowserPrivacy</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <key>app_highlights</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>async_frame_and_overflow_scrolling</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>gpu_process_canvas_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_dom_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_media</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webgl</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webrtc</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>InAppBrowserPrivacy</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>incremental_pdf</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
<key>sw_vp9_decoder_on_battery</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
<key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>WebGL2</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebGPU</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebXR</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>RB_full_manage_WK_jetsam</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>WebGL2</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebGPU</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebXR</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>webm_format_reader</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>webm_parser</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>RB_full_manage_WK_jetsam</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (274854 => 274855)
--- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2021-03-23 08:56:32 UTC (rev 274854)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist 2021-03-23 09:15:24 UTC (rev 274855)
@@ -2,90 +2,90 @@
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
- <key>app_highlights</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>async_frame_and_overflow_scrolling</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>gpu_process_canvas_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_dom_rendering</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_media</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webgl</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>gpu_process_webrtc</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>InAppBrowserPrivacy</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>incremental_pdf</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <key>app_highlights</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>async_frame_and_overflow_scrolling</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>gpu_process_canvas_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_dom_rendering</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_media</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webgl</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>gpu_process_webrtc</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>InAppBrowserPrivacy</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>incremental_pdf</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
<key>sw_vp9_decoder_on_battery</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
<key>vp9_decoder</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>WebGL2</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebGPU</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>WebXR</key>
- <dict>
- <key>Enabled</key>
- <false/>
- </dict>
- <key>webm_format_reader</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>webm_parser</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
- <key>RB_full_manage_WK_jetsam</key>
- <dict>
- <key>Enabled</key>
- <true/>
- </dict>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>WebGL2</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebGPU</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>WebXR</key>
+ <dict>
+ <key>Enabled</key>
+ <false/>
+ </dict>
+ <key>webm_format_reader</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>webm_parser</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
+ <key>RB_full_manage_WK_jetsam</key>
+ <dict>
+ <key>Enabled</key>
+ <true/>
+ </dict>
</dict>
</plist>
Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (274854 => 274855)
--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-03-23 08:56:32 UTC (rev 274854)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp 2021-03-23 09:15:24 UTC (rev 274855)
@@ -185,12 +185,11 @@
{
#if HAVE(SYSTEM_FEATURE_FLAGS)
#if PLATFORM(MAC)
- return true;
+ return false;
#elif PLATFORM(IOS_FAMILY)
return isFeatureFlagEnabled("gpu_process_media");
#endif
#endif
-
return false;
}
@@ -205,8 +204,8 @@
bool defaultCaptureVideoInGPUProcessEnabled()
{
-#if PLATFORM(IOS)
- return true;
+#if PLATFORM(MAC)
+ return false;
#elif HAVE(SYSTEM_FEATURE_FLAGS)
return isFeatureFlagEnabled("gpu_process_webrtc");
#else
@@ -220,9 +219,7 @@
bool defaultWebRTCCodecsInGPUProcess()
{
-#if PLATFORM(COCOA)
- return true;
-#elif HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS)
return isFeatureFlagEnabled("gpu_process_webrtc");
#else
return false;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
