Title: [274861] trunk/Source/WebCore
- Revision
- 274861
- Author
- [email protected]
- Date
- 2021-03-23 06:15:48 -0700 (Tue, 23 Mar 2021)
Log Message
REGRESSION(r274860): error: ‘class WebCore::ExtensionsGLOpenGLCommon’ has no member named ‘drawArraysInstancedANGLE’
https://bugs.webkit.org/show_bug.cgi?id=223633
Unreviewed build fix.
Fix WPE build by adding the functions to ExtensionsGLOpenGLCommon as pure virtual functions.
Patch by Kimmo Kinnunen <[email protected]> on 2021-03-23
* platform/graphics/opengl/ExtensionsGLOpenGL.h:
* platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (274860 => 274861)
--- trunk/Source/WebCore/ChangeLog 2021-03-23 10:57:15 UTC (rev 274860)
+++ trunk/Source/WebCore/ChangeLog 2021-03-23 13:15:48 UTC (rev 274861)
@@ -1,5 +1,17 @@
2021-03-23 Kimmo Kinnunen <[email protected]>
+ REGRESSION(r274860): error: ‘class WebCore::ExtensionsGLOpenGLCommon’ has no member named ‘drawArraysInstancedANGLE’
+ https://bugs.webkit.org/show_bug.cgi?id=223633
+
+ Unreviewed build fix.
+
+ Fix WPE build by adding the functions to ExtensionsGLOpenGLCommon as pure virtual functions.
+
+ * platform/graphics/opengl/ExtensionsGLOpenGL.h:
+ * platform/graphics/opengl/ExtensionsGLOpenGLCommon.h:
+
+2021-03-23 Kimmo Kinnunen <[email protected]>
+
Move instanced drawing functionality from ExtensionsGL to GraphicsContextGL
https://bugs.webkit.org/show_bug.cgi?id=223179
Modified: trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGL.h (274860 => 274861)
--- trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGL.h 2021-03-23 10:57:15 UTC (rev 274860)
+++ trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGL.h 2021-03-23 13:15:48 UTC (rev 274861)
@@ -47,9 +47,9 @@
void bindVertexArrayOES(PlatformGLObject) override;
void drawBuffersEXT(GCGLSpan<const GCGLenum>) override;
- void drawArraysInstancedANGLE(GCGLenum mode, GCGLint first, GCGLsizei count, GCGLsizei primcount);
- void drawElementsInstancedANGLE(GCGLenum mode, GCGLsizei count, GCGLenum type, GCGLvoidptr offset, GCGLsizei primcount);
- void vertexAttribDivisorANGLE(GCGLuint index, GCGLuint divisor);
+ void drawArraysInstancedANGLE(GCGLenum mode, GCGLint first, GCGLsizei count, GCGLsizei primcount) override;
+ void drawElementsInstancedANGLE(GCGLenum mode, GCGLsizei count, GCGLenum type, GCGLvoidptr offset, GCGLsizei primcount) override;
+ void vertexAttribDivisorANGLE(GCGLuint index, GCGLuint divisor) override;
protected:
bool supportsExtension(const WTF::String&) override;
Modified: trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h (274860 => 274861)
--- trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h 2021-03-23 10:57:15 UTC (rev 274860)
+++ trunk/Source/WebCore/platform/graphics/opengl/ExtensionsGLOpenGLCommon.h 2021-03-23 13:15:48 UTC (rev 274861)
@@ -56,6 +56,10 @@
String getTranslatedShaderSourceANGLE(PlatformGLObject) override;
+ virtual void drawArraysInstancedANGLE(GCGLenum mode, GCGLint first, GCGLsizei count, GCGLsizei primcount) = 0;
+ virtual void drawElementsInstancedANGLE(GCGLenum mode, GCGLsizei count, GCGLenum type, GCGLvoidptr offset, GCGLsizei primcount) = 0;
+ virtual void vertexAttribDivisorANGLE(GCGLuint index, GCGLuint divisor) = 0;
+
// EXT Robustness - uses getGraphicsResetStatusARB()
void readnPixelsEXT(int x, int y, GCGLsizei width, GCGLsizei height, GCGLenum format, GCGLenum type, GCGLsizei bufSize, void *data) override;
void getnUniformfvEXT(GCGLuint program, int location, GCGLsizei bufSize, float *params) override;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
