Title: [274976] trunk
- Revision
- 274976
- Author
- [email protected]
- Date
- 2021-03-24 14:57:23 -0700 (Wed, 24 Mar 2021)
Log Message
REGRESSION(r274870) fast/canvas/webgl/texImage2D-mse-flipY-true.html and fast/canvas/webgl/texImage2D-mse-flipY-false.html are crashing
https://bugs.webkit.org/show_bug.cgi?id=223674
Patch by Philippe Normand <[email protected]> on 2021-03-24
Reviewed by Kenneth Russell.
Source/WebCore:
When the srcObject is directly set on a media element, the corresponding URL might still be
empty, so we need to ensure the URI corresponding to the MediaSource blob is not empty,
otherwise uridecodebin would fail to create the right source element.
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
LayoutTests:
* platform/glib/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (274975 => 274976)
--- trunk/LayoutTests/ChangeLog 2021-03-24 21:32:37 UTC (rev 274975)
+++ trunk/LayoutTests/ChangeLog 2021-03-24 21:57:23 UTC (rev 274976)
@@ -1,3 +1,12 @@
+2021-03-24 Philippe Normand <[email protected]>
+
+ REGRESSION(r274870) fast/canvas/webgl/texImage2D-mse-flipY-true.html and fast/canvas/webgl/texImage2D-mse-flipY-false.html are crashing
+ https://bugs.webkit.org/show_bug.cgi?id=223674
+
+ Reviewed by Kenneth Russell.
+
+ * platform/glib/TestExpectations:
+
2021-03-24 Chris Gambrell <[email protected]>
[LayoutTests] Convert http/tests/resourceLoadStatistics convert PHP to Python
Modified: trunk/LayoutTests/platform/glib/TestExpectations (274975 => 274976)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-03-24 21:32:37 UTC (rev 274975)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-03-24 21:57:23 UTC (rev 274976)
@@ -554,9 +554,8 @@
webkit.org/b/220540 media/media-fullscreen-inline.html [ Timeout ]
-# 223674 for Crash, revert to Timeout for 179258
-webkit.org/b/179258 webkit.org/b/223674 fast/canvas/webgl/texImage2D-mse-flipY-false.html [ Crash ]
-webkit.org/b/179258 webkit.org/b/223674 fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Crash ]
+webkit.org/b/179258 fast/canvas/webgl/texImage2D-mse-flipY-false.html [ Timeout ]
+webkit.org/b/179258 fast/canvas/webgl/texImage2D-mse-flipY-true.html [ Timeout ]
#////////////////////////////////////////////////////////////////////////////////////////
# End of GStreamer-related bugs
Modified: trunk/Source/WebCore/ChangeLog (274975 => 274976)
--- trunk/Source/WebCore/ChangeLog 2021-03-24 21:32:37 UTC (rev 274975)
+++ trunk/Source/WebCore/ChangeLog 2021-03-24 21:57:23 UTC (rev 274976)
@@ -1,3 +1,17 @@
+2021-03-24 Philippe Normand <[email protected]>
+
+ REGRESSION(r274870) fast/canvas/webgl/texImage2D-mse-flipY-true.html and fast/canvas/webgl/texImage2D-mse-flipY-false.html are crashing
+ https://bugs.webkit.org/show_bug.cgi?id=223674
+
+ Reviewed by Kenneth Russell.
+
+ When the srcObject is directly set on a media element, the corresponding URL might still be
+ empty, so we need to ensure the URI corresponding to the MediaSource blob is not empty,
+ otherwise uridecodebin would fail to create the right source element.
+
+ * platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
+ (WebCore::MediaPlayerPrivateGStreamerMSE::load):
+
2021-03-24 Aditya Keerthi <[email protected]>
REGRESSION (r273154): [iOS] Two magnifier symbols on google.com
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp (274975 => 274976)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp 2021-03-24 21:32:37 UTC (rev 274975)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp 2021-03-24 21:57:23 UTC (rev 274976)
@@ -130,7 +130,8 @@
void MediaPlayerPrivateGStreamerMSE::load(const URL& url, const ContentType&, MediaSourcePrivateClient* mediaSource)
{
- GST_DEBUG("Loading %s", url.string().ascii().data());
+ auto mseBlobURI = makeString("mediasource", url.string().isEmpty() ? "blob://" : url.string());
+ GST_DEBUG("Loading %s", mseBlobURI.ascii().data());
m_mediaSource = mediaSource;
if (!m_playbackPipeline)
@@ -138,7 +139,7 @@
m_mediaSourcePrivate = MediaSourcePrivateGStreamer::open(*m_mediaSource.get(), *this);
- MediaPlayerPrivateGStreamer::load(makeString("mediasource", url.string()));
+ MediaPlayerPrivateGStreamer::load(mseBlobURI);
}
void MediaPlayerPrivateGStreamerMSE::pause()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
