Title: [274984] trunk/LayoutTests
- Revision
- 274984
- Author
- [email protected]
- Date
- 2021-03-24 17:04:42 -0700 (Wed, 24 Mar 2021)
Log Message
REGRESSION(r274919) [ATK] accessibility/set-selected-text-range-contenteditable.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=223710
Reviewed by Adrian Perez de Castro.
r274919 clamped the values passed to the accessibility elements,
making the {-1,0} text range to be collapsed to {0,0} as text ranges
are composed of unsigned ints.
This commit updates the test to remove the ATK-specific case of
passing -1 to point to the final offset of a text range.
* accessibility/set-selected-text-range-contenteditable.html: Remove
ATK-specific quirk.
* platform/glib/accessibility/set-selected-text-range-contenteditable-expected.txt: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (274983 => 274984)
--- trunk/LayoutTests/ChangeLog 2021-03-24 23:14:51 UTC (rev 274983)
+++ trunk/LayoutTests/ChangeLog 2021-03-25 00:04:42 UTC (rev 274984)
@@ -1,3 +1,21 @@
+2021-03-24 Lauro Moura <[email protected]>
+
+ REGRESSION(r274919) [ATK] accessibility/set-selected-text-range-contenteditable.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=223710
+
+ Reviewed by Adrian Perez de Castro.
+
+ r274919 clamped the values passed to the accessibility elements,
+ making the {-1,0} text range to be collapsed to {0,0} as text ranges
+ are composed of unsigned ints.
+
+ This commit updates the test to remove the ATK-specific case of
+ passing -1 to point to the final offset of a text range.
+
+ * accessibility/set-selected-text-range-contenteditable.html: Remove
+ ATK-specific quirk.
+ * platform/glib/accessibility/set-selected-text-range-contenteditable-expected.txt: Removed.
+
2021-03-24 Eric Carlson <[email protected]>
[Cocoa] Add Experimental MediaSession coordinator
Modified: trunk/LayoutTests/accessibility/set-selected-text-range-contenteditable.html (274983 => 274984)
--- trunk/LayoutTests/accessibility/set-selected-text-range-contenteditable.html 2021-03-24 23:14:51 UTC (rev 274983)
+++ trunk/LayoutTests/accessibility/set-selected-text-range-contenteditable.html 2021-03-25 00:04:42 UTC (rev 274984)
@@ -44,11 +44,7 @@
shouldBecomeEqual("content.selectedTextRange", "'{1, 12}'", function() {
debug("\nSet range: {-1, 0}");
content.setSelectedTextRange(-1, 0);
-
- // In ATK, -1 is used as an alias for the final offset.
- expectations = accessibilityController.platformName == "atk" ? "'{16, 0}'" : "'{0, 0}'";
-
- shouldBecomeEqual("content.selectedTextRange", expectations, function() {
+ shouldBecomeEqual("content.selectedTextRange", "'{0, 0}'", function() {
debug("\nSet range: {7, 3}");
content.setSelectedTextRange(7, 3);
shouldBecomeEqual("content.selectedTextRange", "'{7, 3}'", finishJSTest);
Deleted: trunk/LayoutTests/platform/glib/accessibility/set-selected-text-range-contenteditable-expected.txt (274983 => 274984)
--- trunk/LayoutTests/platform/glib/accessibility/set-selected-text-range-contenteditable-expected.txt 2021-03-24 23:14:51 UTC (rev 274983)
+++ trunk/LayoutTests/platform/glib/accessibility/set-selected-text-range-contenteditable-expected.txt 2021-03-25 00:04:42 UTC (rev 274984)
@@ -1,29 +0,0 @@
-hello world test
-This tests that selected text ranges can be set on a contenteditable element.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-Initial selected range: {1, 0}
-
-Set range: {3, 0}
-PASS content.selectedTextRange became '{3, 0}'
-
-Set range: {100, 0}
-PASS content.selectedTextRange became '{16, 0}'
-
-Set range: {0, 0}
-PASS content.selectedTextRange became '{0, 0}'
-
-Set range: {1, 12}
-PASS content.selectedTextRange became '{1, 12}'
-
-Set range: {-1, 0}
-PASS content.selectedTextRange became '{16, 0}'
-
-Set range: {7, 3}
-PASS content.selectedTextRange became '{7, 3}'
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
