Title: [274992] trunk/Source/WebCore
- Revision
- 274992
- Author
- [email protected]
- Date
- 2021-03-24 18:28:46 -0700 (Wed, 24 Mar 2021)
Log Message
Port FontDescriptionKey::computeHash() from legacy IntegerHasher to Hasher
https://bugs.webkit.org/show_bug.cgi?id=223701
Reviewed by Darin Adler.
Port FontDescriptionKey::computeHash() from legacy IntegerHasher to Hasher. Hasher
has the benefit of having add() overloads that take in signed integer types.
* platform/graphics/FontCache.h:
(WebCore::FontDescriptionKey::computeHash const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (274991 => 274992)
--- trunk/Source/WebCore/ChangeLog 2021-03-25 01:24:51 UTC (rev 274991)
+++ trunk/Source/WebCore/ChangeLog 2021-03-25 01:28:46 UTC (rev 274992)
@@ -1,5 +1,18 @@
2021-03-24 Chris Dumez <[email protected]>
+ Port FontDescriptionKey::computeHash() from legacy IntegerHasher to Hasher
+ https://bugs.webkit.org/show_bug.cgi?id=223701
+
+ Reviewed by Darin Adler.
+
+ Port FontDescriptionKey::computeHash() from legacy IntegerHasher to Hasher. Hasher
+ has the benefit of having add() overloads that take in signed integer types.
+
+ * platform/graphics/FontCache.h:
+ (WebCore::FontDescriptionKey::computeHash const):
+
+2021-03-24 Chris Dumez <[email protected]>
+
Extend WebAudio heap allocation assertions to cover the pre & post-rendering phases
https://bugs.webkit.org/show_bug.cgi?id=223640
Modified: trunk/Source/WebCore/platform/graphics/FontCache.h (274991 => 274992)
--- trunk/Source/WebCore/platform/graphics/FontCache.h 2021-03-25 01:24:51 UTC (rev 274991)
+++ trunk/Source/WebCore/platform/graphics/FontCache.h 2021-03-25 01:28:46 UTC (rev 274992)
@@ -108,16 +108,13 @@
inline unsigned computeHash() const
{
- IntegerHasher hasher;
- hasher.add(m_size);
- hasher.add(m_fontSelectionRequest.weight);
- hasher.add(m_fontSelectionRequest.width);
- hasher.add(m_fontSelectionRequest.slope.valueOr(normalItalicValue()));
- hasher.add(m_locale.existingHash());
- for (unsigned flagItem : m_flags)
- hasher.add(flagItem);
- hasher.add(m_featureSettings.hash());
- hasher.add(m_variationSettings.hash());
+ Hasher hasher;
+ add(hasher, m_size);
+ add(hasher, m_fontSelectionRequest.tied());
+ add(hasher, m_locale.existingHash());
+ add(hasher, m_flags);
+ add(hasher, m_featureSettings.hash());
+ add(hasher, m_variationSettings.hash());
return hasher.hash();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
