Title: [275014] trunk/Source/WTF
Revision
275014
Author
[email protected]
Date
2021-03-25 05:10:54 -0700 (Thu, 25 Mar 2021)

Log Message

REGRESSION(r271560): [Linux] release assert in Thread::initializePlatformThreading
https://bugs.webkit.org/show_bug.cgi?id=223069

Reviewed by Carlos Garcia Campos.

Replace an existing signal handler instead of aborting.

* wtf/posix/ThreadingPOSIX.cpp:
(WTF::Thread::initializePlatformThreading):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (275013 => 275014)


--- trunk/Source/WTF/ChangeLog	2021-03-25 10:14:43 UTC (rev 275013)
+++ trunk/Source/WTF/ChangeLog	2021-03-25 12:10:54 UTC (rev 275014)
@@ -1,3 +1,15 @@
+2021-03-25  Alberto Garcia  <[email protected]>
+
+        REGRESSION(r271560): [Linux] release assert in Thread::initializePlatformThreading
+        https://bugs.webkit.org/show_bug.cgi?id=223069
+
+        Reviewed by Carlos Garcia Campos.
+
+        Replace an existing signal handler instead of aborting.
+
+        * wtf/posix/ThreadingPOSIX.cpp:
+        (WTF::Thread::initializePlatformThreading):
+
 2021-03-24  Mark Lam  <[email protected]>
 
         WTF::setPermissionsOfConfigPage() should allow its VM_FLAGS_PERMANENT workaround unconditionally.

Modified: trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp (275013 => 275014)


--- trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp	2021-03-25 10:14:43 UTC (rev 275013)
+++ trunk/Source/WTF/wtf/posix/ThreadingPOSIX.cpp	2021-03-25 12:10:54 UTC (rev 275014)
@@ -209,7 +209,7 @@
             return false;
         // It has signal already.
         if (oldAction.sa_handler != SIG_DFL || bitwise_cast<void*>(oldAction.sa_sigaction) != bitwise_cast<void*>(SIG_DFL))
-            return false;
+            WTFLogAlways("Overriding existing handler for signal %d. Set JSC_SIGNAL_FOR_GC if you want WebKit to use a different signal", signal);
         return !sigaction(signal, &action, 0);
     };
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to