Title: [275016] trunk/Source/WebInspectorUI
- Revision
- 275016
- Author
- [email protected]
- Date
- 2021-03-25 06:41:51 -0700 (Thu, 25 Mar 2021)
Log Message
REGRESSION (r270134) Web Inspector: Audit: Results are stacked on top of each other.
https://bugs.webkit.org/show_bug.cgi?id=223381
<rdar://problem/75528374>
Reviewed by Devin Rousso.
Ensure pre-existing `ContentView`s are removed when navigating back/forward
even when the incoming `ContentView` is already attached.
For example, `AuditTestContentView` instances for individual tests are already attached
when shown as part of a test group `AuditTestGroupContentView`.
Navigating from the group to the individual test view must remove the group view.
* UserInterface/Views/ContentViewContainer.js:
(WI.ContentViewContainer.prototype.showBackForwardEntryForIndex):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (275015 => 275016)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-03-25 12:22:22 UTC (rev 275015)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-03-25 13:41:51 UTC (rev 275016)
@@ -1,3 +1,21 @@
+2021-03-25 Razvan Caliman <[email protected]>
+
+ REGRESSION (r270134) Web Inspector: Audit: Results are stacked on top of each other.
+ https://bugs.webkit.org/show_bug.cgi?id=223381
+ <rdar://problem/75528374>
+
+ Reviewed by Devin Rousso.
+
+ Ensure pre-existing `ContentView`s are removed when navigating back/forward
+ even when the incoming `ContentView` is already attached.
+
+ For example, `AuditTestContentView` instances for individual tests are already attached
+ when shown as part of a test group `AuditTestGroupContentView`.
+ Navigating from the group to the individual test view must remove the group view.
+
+ * UserInterface/Views/ContentViewContainer.js:
+ (WI.ContentViewContainer.prototype.showBackForwardEntryForIndex):
+
2021-03-24 Razvan Caliman <[email protected]>
Web Inspector: REGRESSION (r269359): Timelines: TypeError: this.deselect is not a function
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js (275015 => 275016)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js 2021-03-25 12:22:22 UTC (rev 275015)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js 2021-03-25 13:41:51 UTC (rev 275016)
@@ -157,7 +157,7 @@
var currentEntry = this.currentBackForwardEntry;
console.assert(currentEntry);
- if (previousEntry && !currentEntry.contentView.isAttached)
+ if (previousEntry && (!currentEntry.contentView.isAttached || previousEntry.contentView !== currentEntry.contentView))
this._hideEntry(previousEntry);
this._showEntry(currentEntry);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
