Title: [275045] trunk/Source/WebCore
- Revision
- 275045
- Author
- [email protected]
- Date
- 2021-03-25 10:16:06 -0700 (Thu, 25 Mar 2021)
Log Message
Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally()
https://bugs.webkit.org/show_bug.cgi?id=223749
Reviewed by Antti Koivisto.
Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally(). Based on the comment,
it looks like the intention was to prewarm some font families. However, looking at the code, nothing
that gets populated is global and survives the destruction of the Settings object on the next line.
We don't even make any calls to CTFont.
* page/ProcessWarming.cpp:
(WebCore::ProcessWarming::prewarmGlobally):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (275044 => 275045)
--- trunk/Source/WebCore/ChangeLog 2021-03-25 17:06:40 UTC (rev 275044)
+++ trunk/Source/WebCore/ChangeLog 2021-03-25 17:16:06 UTC (rev 275045)
@@ -1,3 +1,18 @@
+2021-03-25 Chris Dumez <[email protected]>
+
+ Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally()
+ https://bugs.webkit.org/show_bug.cgi?id=223749
+
+ Reviewed by Antti Koivisto.
+
+ Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally(). Based on the comment,
+ it looks like the intention was to prewarm some font families. However, looking at the code, nothing
+ that gets populated is global and survives the destruction of the Settings object on the next line.
+ We don't even make any calls to CTFont.
+
+ * page/ProcessWarming.cpp:
+ (WebCore::ProcessWarming::prewarmGlobally):
+
2021-03-25 Youenn Fablet <[email protected]>
Switch from PORTALLOCATOR_DISABLE_ADAPTER_ENUMERATION to filtering interfaces in Network process
Modified: trunk/Source/WebCore/page/ProcessWarming.cpp (275044 => 275045)
--- trunk/Source/WebCore/page/ProcessWarming.cpp 2021-03-25 17:06:40 UTC (rev 275044)
+++ trunk/Source/WebCore/page/ProcessWarming.cpp 2021-03-25 17:16:06 UTC (rev 275045)
@@ -35,7 +35,6 @@
#include "MediaFeatureNames.h"
#include "QualifiedName.h"
#include "SVGNames.h"
-#include "Settings.h"
#include "TelephoneNumberDetector.h"
#include "UserAgentStyle.h"
#include "WebKitFontFamilyNames.h"
@@ -68,9 +67,6 @@
{
initializeNames();
- // Initializes default font families.
- Settings::create(nullptr);
-
// Prewarms user agent stylesheet.
Style::UserAgentStyle::initDefaultStyleSheet();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
