Title: [275085] trunk/Source/WebCore
Revision
275085
Author
[email protected]
Date
2021-03-26 02:37:51 -0700 (Fri, 26 Mar 2021)

Log Message

REGRESSION(r272301): [SOUP] default port attribute when persisting credential information with libsecret
https://bugs.webkit.org/show_bug.cgi?id=223782

Reviewed by Adrian Perez de Castro.

Use the default port instead of 0 when the URL omits the port.

* platform/network/soup/AuthenticationChallengeSoup.cpp:
(WebCore::protectionSpaceFromSoupAuthAndURL):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (275084 => 275085)


--- trunk/Source/WebCore/ChangeLog	2021-03-26 09:25:21 UTC (rev 275084)
+++ trunk/Source/WebCore/ChangeLog	2021-03-26 09:37:51 UTC (rev 275085)
@@ -1,3 +1,15 @@
+2021-03-26  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r272301): [SOUP] default port attribute when persisting credential information with libsecret
+        https://bugs.webkit.org/show_bug.cgi?id=223782
+
+        Reviewed by Adrian Perez de Castro.
+
+        Use the default port instead of 0 when the URL omits the port.
+
+        * platform/network/soup/AuthenticationChallengeSoup.cpp:
+        (WebCore::protectionSpaceFromSoupAuthAndURL):
+
 2021-03-26  Yusuke Suzuki  <[email protected]>
 
         Use ICUDeleter to encode ucnv_close/uenum_close call into type of deleter of std::unique_ptr

Modified: trunk/Source/WebCore/platform/network/soup/AuthenticationChallengeSoup.cpp (275084 => 275085)


--- trunk/Source/WebCore/platform/network/soup/AuthenticationChallengeSoup.cpp	2021-03-26 09:25:21 UTC (rev 275084)
+++ trunk/Source/WebCore/platform/network/soup/AuthenticationChallengeSoup.cpp	2021-03-26 09:37:51 UTC (rev 275085)
@@ -64,6 +64,8 @@
 #if USE(SOUP2)
     auto host = url.host();
     auto port = url.port();
+    if (!port)
+        port = defaultPortForProtocol(url.protocol());
 #else
     URL authURL({ }, makeString("http://", soup_auth_get_authority(soupAuth)));
     auto host = authURL.host();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to