Title: [275136] trunk/Source/WebKit
- Revision
- 275136
- Author
- [email protected]
- Date
- 2021-03-27 11:31:30 -0700 (Sat, 27 Mar 2021)
Log Message
Remove DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread()
https://bugs.webkit.org/show_bug.cgi?id=223837
Patch by Tyler Wilcock <[email protected]> on 2021-03-27
Reviewed by Simon Fraser.
Fixes build for GTK + WPE after
https://trac.webkit.org/changeset/275134/webkit.
Quoting that revision:
> handleDisplayRefreshedNotificationOnMainThread() is an anachronism left over from
> the non-main-thread nature of the CVDisplayLink callback. There's no need to burden
> all subclasses of DisplayRefreshMonitor with that detail.
* Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::invalidate):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):
Replace call to DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this)
with displayDidRefresh().
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (275135 => 275136)
--- trunk/Source/WebKit/ChangeLog 2021-03-27 17:15:19 UTC (rev 275135)
+++ trunk/Source/WebKit/ChangeLog 2021-03-27 18:31:30 UTC (rev 275136)
@@ -1,3 +1,25 @@
+2021-03-27 Tyler Wilcock <[email protected]>
+
+ Remove DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread()
+ https://bugs.webkit.org/show_bug.cgi?id=223837
+
+ Reviewed by Simon Fraser.
+
+ Fixes build for GTK + WPE after
+ https://trac.webkit.org/changeset/275134/webkit.
+
+ Quoting that revision:
+
+ > handleDisplayRefreshedNotificationOnMainThread() is an anachronism left over from
+ > the non-main-thread nature of the CVDisplayLink callback. There's no need to burden
+ > all subclasses of DisplayRefreshMonitor with that detail.
+
+ * Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
+ (WebKit::ThreadedDisplayRefreshMonitor::invalidate):
+ (WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):
+ Replace call to DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this)
+ with displayDidRefresh().
+
2021-03-27 David Kilzer <[email protected]>
Fix leaks in WKInspectorResourceURLSchemeHandler
Modified: trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp (275135 => 275136)
--- trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp 2021-03-27 17:15:19 UTC (rev 275135)
+++ trunk/Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp 2021-03-27 18:31:30 UTC (rev 275136)
@@ -91,7 +91,7 @@
wasScheduled = isScheduled();
}
if (wasScheduled)
- DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this);
+ displayDidRefresh();
m_client = nullptr;
}
@@ -106,7 +106,7 @@
}
if (shouldHandleDisplayRefreshNotification)
- DisplayRefreshMonitor::handleDisplayRefreshedNotificationOnMainThread(this);
+ displayDidRefresh();
// Retrieve the scheduled status for this DisplayRefreshMonitor.
bool hasBeenRescheduled { false };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
