Title: [105747] trunk/Source/WebCore
- Revision
- 105747
- Author
- [email protected]
- Date
- 2012-01-24 10:22:43 -0800 (Tue, 24 Jan 2012)
Log Message
Web Inspector: OpenResourceDialog should work when there are no open tabs in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=76907
Reviewed by Yury Semikhatsky.
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.install):
* inspector/front-end/ScriptsPanel.js:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105746 => 105747)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 18:03:06 UTC (rev 105746)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 18:22:43 UTC (rev 105747)
@@ -1,3 +1,14 @@
+2012-01-24 Vsevolod Vlasov <[email protected]>
+
+ Web Inspector: OpenResourceDialog should work when there are no open tabs in scripts panel.
+ https://bugs.webkit.org/show_bug.cgi?id=76907
+
+ Reviewed by Yury Semikhatsky.
+
+ * inspector/front-end/FilteredItemSelectionDialog.js:
+ (WebInspector.OpenResourceDialog.install):
+ * inspector/front-end/ScriptsPanel.js:
+
2012-01-24 Peter Rybin <[email protected]>
Web Inspector: CodeGeneratorInspector.py: put TypeBuilder namespace in a separate sources
Modified: trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js (105746 => 105747)
--- trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2012-01-24 18:03:06 UTC (rev 105746)
+++ trunk/Source/WebCore/inspector/front-end/FilteredItemSelectionDialog.js 2012-01-24 18:22:43 UTC (rev 105747)
@@ -609,13 +609,11 @@
* @param {WebInspector.ScriptsPanel} panel
* @param {WebInspector.DebuggerPresentationModel} presentationModel
*/
-WebInspector.OpenResourceDialog.install = function(panel, presentationModel, viewGetter)
+WebInspector.OpenResourceDialog.install = function(panel, presentationModel, relativeToElement)
{
function showOpenResourceDialog()
{
- var view = viewGetter();
- if (view)
- WebInspector.OpenResourceDialog._show(panel, presentationModel, view.element);
+ WebInspector.OpenResourceDialog._show(panel, presentationModel, relativeToElement);
}
var openResourceShortcut = WebInspector.OpenResourceDialog.createShortcut();
Modified: trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js (105746 => 105747)
--- trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-01-24 18:03:06 UTC (rev 105746)
+++ trunk/Source/WebCore/inspector/front-end/ScriptsPanel.js 2012-01-24 18:22:43 UTC (rev 105747)
@@ -43,7 +43,6 @@
}
WebInspector.GoToLineDialog.install(this, viewGetter.bind(this));
WebInspector._javascript_OutlineDialog.install(this, viewGetter.bind(this));
- WebInspector.OpenResourceDialog.install(this, this._presentationModel, viewGetter.bind(this));
this.debugToolbar = this._createDebugToolbar();
@@ -80,12 +79,14 @@
this._editorContainer = new WebInspector.TabbedEditorContainer();
this._editorContainer.show(this.editorView.mainElement);
+ WebInspector.OpenResourceDialog.install(this, this._presentationModel, this.editorView.mainElement);
} else {
this._fileSelector = new WebInspector.ScriptsPanel.ComboBoxFileSelector(this._presentationModel);
this._fileSelector.show(this.splitView.mainElement);
this._editorContainer = new WebInspector.ScriptsPanel.SingleFileEditorContainer();
this._editorContainer.show(this.splitView.mainElement);
+ WebInspector.OpenResourceDialog.install(this, this._presentationModel, this.splitView.mainElement);
}
this._fileSelector.addEventListener(WebInspector.ScriptsPanel.FileSelector.Events.FileSelected, this._fileSelected, this);
this._fileSelector.addEventListener(WebInspector.ScriptsPanel.FileSelector.Events.ReleasedFocusAfterSelection, this._fileSelectorReleasedFocus, this);
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
