Title: [275143] trunk/Source/WebCore
- Revision
- 275143
- Author
- [email protected]
- Date
- 2021-03-27 17:40:03 -0700 (Sat, 27 Mar 2021)
Log Message
Don't add Frame as an opaque root of DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=223838
Reviewed by Simon Fraser.
Don't add Frame as an opaque root of DOMWindow since we don't use Frame
as an opaque root of any JS wrappers since r248276.
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::visitAdditionalChildren):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (275142 => 275143)
--- trunk/Source/WebCore/ChangeLog 2021-03-27 23:26:45 UTC (rev 275142)
+++ trunk/Source/WebCore/ChangeLog 2021-03-28 00:40:03 UTC (rev 275143)
@@ -1,3 +1,16 @@
+2021-03-27 Ryosuke Niwa <[email protected]>
+
+ Don't add Frame as an opaque root of DOMWindow
+ https://bugs.webkit.org/show_bug.cgi?id=223838
+
+ Reviewed by Simon Fraser.
+
+ Don't add Frame as an opaque root of DOMWindow since we don't use Frame
+ as an opaque root of any JS wrappers since r248276.
+
+ * bindings/js/JSDOMWindowCustom.cpp:
+ (WebCore::JSDOMWindow::visitAdditionalChildren):
+
2021-03-27 David Kilzer <[email protected]>
UBSan: runtime error: load of value <unknown>, which is not a valid value for type 'const WebCore::RealtimeMediaSourceCapabilities::EchoCancellation'
Modified: trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp (275142 => 275143)
--- trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2021-03-27 23:26:45 UTC (rev 275142)
+++ trunk/Source/WebCore/bindings/js/JSDOMWindowCustom.cpp 2021-03-28 00:40:03 UTC (rev 275143)
@@ -71,9 +71,6 @@
template<typename Visitor>
void JSDOMWindow::visitAdditionalChildren(Visitor& visitor)
{
- if (Frame* frame = wrapped().frame())
- visitor.addOpaqueRoot(frame);
-
visitor.addOpaqueRoot(&wrapped());
// Normally JSEventTargetCustom.cpp's JSEventTarget::visitAdditionalChildren() would call this. But
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
