Title: [275159] trunk
Revision
275159
Author
[email protected]
Date
2021-03-28 22:27:15 -0700 (Sun, 28 Mar 2021)

Log Message

Enable AspectRatioOfImgFromWidthAndHeightEnabled for WebKitLegacy.
https://bugs.webkit.org/show_bug.cgi?id=223815

Reviewed by Sam Weinig.

Source/WTF:

There's no reason this is enabled for WebKit and not WebKitLegacy.
And set WebCore = true since this feature could conceivably be
used in SVG images.

* Scripts/Preferences/WebPreferencesExperimental.yaml:

Tools:

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (275158 => 275159)


--- trunk/Source/WTF/ChangeLog	2021-03-29 05:14:19 UTC (rev 275158)
+++ trunk/Source/WTF/ChangeLog	2021-03-29 05:27:15 UTC (rev 275159)
@@ -1,3 +1,16 @@
+2021-03-28  Cameron McCormack  <[email protected]>
+
+        Enable AspectRatioOfImgFromWidthAndHeightEnabled for WebKitLegacy.
+        https://bugs.webkit.org/show_bug.cgi?id=223815
+
+        Reviewed by Sam Weinig.
+
+        There's no reason this is enabled for WebKit and not WebKitLegacy.
+        And set WebCore = true since this feature could conceivably be
+        used in SVG images.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
 2021-03-28  Sam Weinig  <[email protected]>
 
         Remove ENABLE_INDEXED_DATABASE & ENABLE_INDEXED_DATABASE_IN_WORKERS, it seems like it is on for all ports

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (275158 => 275159)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-03-29 05:14:19 UTC (rev 275158)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-03-29 05:27:15 UTC (rev 275159)
@@ -49,7 +49,6 @@
     WebCore:
       default: true
 
-# FIXME: This is on by default in WebKit2. Perhaps we should consider turning it on for WebKitLegacy as well.
 AspectRatioOfImgFromWidthAndHeightEnabled:
   type: bool
   humanReadableName: "Aspect ratio of <img> from width and height"
@@ -56,11 +55,11 @@
   humanReadableDescription: "Map HTML attributes width/height to the default aspect ratio of <img>"
   defaultValue:
     WebKitLegacy:
-      default: false
+      default: true
     WebKit:
       default: true
     WebCore:
-      default: false
+      default: true
 
 # FIXME: This is on by default in WebKit2 PLATFORM(COCOA). Perhaps we should consider turning it on for WebKitLegacy as well.
 AsyncClipboardAPIEnabled:

Modified: trunk/Tools/ChangeLog (275158 => 275159)


--- trunk/Tools/ChangeLog	2021-03-29 05:14:19 UTC (rev 275158)
+++ trunk/Tools/ChangeLog	2021-03-29 05:27:15 UTC (rev 275159)
@@ -1,3 +1,13 @@
+2021-03-28  Cameron McCormack  <[email protected]>
+
+        Enable AspectRatioOfImgFromWidthAndHeightEnabled for WebKitLegacy.
+        https://bugs.webkit.org/show_bug.cgi?id=223815
+
+        Reviewed by Sam Weinig.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (WTR::TestOptions::defaults):
+
 2021-03-27  Dewei Zhu  <[email protected]>
 
         Fix a bug that http server for run-benchmark script does not work on python3.

Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (275158 => 275159)


--- trunk/Tools/DumpRenderTree/TestOptions.cpp	2021-03-29 05:14:19 UTC (rev 275158)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp	2021-03-29 05:27:15 UTC (rev 275159)
@@ -107,7 +107,6 @@
             // FIXME: These experimental features are currently the only ones not enabled for WebKitLegacy, we
             // should either enable them or stop exposing them (as we do with with preferences like HTTP3Enabled).
             // All other experimental features are automatically enabled regardless of their specified defaults.
-            { "AspectRatioOfImgFromWidthAndHeightEnabled", false },
             { "AsyncClipboardAPIEnabled", false },
             { "CSSOMViewSmoothScrollingEnabled", false },
             { "ContactPickerAPIEnabled", false },
@@ -129,7 +128,6 @@
             { "AllowFileAccessFromFileURLs", true },
             { "AllowTopNavigationToDataURLs", true },
             { "AllowUniversalAccessFromFileURLs", true },
-            { "AspectRatioOfImgFromWidthAndHeightEnabled", false },
             { "AspectRatioEnabled", true },
             { "AsyncClipboardAPIEnabled", false },
             { "AttachmentElementEnabled", false },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to