Skip to site navigation (Press enter)

[webkit-changes] [275207] trunk/Source/WebKit

peng . liu6 Tue, 30 Mar 2021 09:32:40 -0700

Title: [275207] trunk/Source/WebKit

Revision: 275207
Author: [email protected]
Date: 2021-03-30 09:32:01 -0700 (Tue, 30 Mar 2021)

Log Message

[GPUP] Add "CodeComplete" attribute to some feature flags
https://bugs.webkit.org/show_bug.cgi?id=223907


Reviewed by Daniel Bates.

Add "CodeComplete" attribute for three feature flags:
- gpu_process_canvas_rendering
- gpu_process_media
- gpu_process_webrtc

Also replace tabs in the plist files with spaces.

* FeatureFlags/WebKit-appletvos.plist:
* FeatureFlags/WebKit-ios.plist:
* FeatureFlags/WebKit-macos.plist:
* FeatureFlags/WebKit-watchos.plist:
* Scripts/combine-feature-flags-plist.py:
(main): Fix an issue to merge "attributes".

Modified Paths

trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist
trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist
trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist
trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist
trunk/Source/WebKit/Scripts/combine-feature-flags-plist.py

Diff

Modified: trunk/Source/WebKit/ChangeLog (275206 => 275207)


--- trunk/Source/WebKit/ChangeLog	2021-03-30 16:31:21 UTC (rev 275206)
+++ trunk/Source/WebKit/ChangeLog	2021-03-30 16:32:01 UTC (rev 275207)
@@ -1,3 +1,24 @@
+2021-03-30  Peng Liu  <[email protected]>
+
+        [GPUP] Add "CodeComplete" attribute to some feature flags
+        https://bugs.webkit.org/show_bug.cgi?id=223907
+
+        Reviewed by Daniel Bates.
+
+        Add "CodeComplete" attribute for three feature flags:
+        - gpu_process_canvas_rendering
+        - gpu_process_media
+        - gpu_process_webrtc
+
+        Also replace tabs in the plist files with spaces.
+
+        * FeatureFlags/WebKit-appletvos.plist:
+        * FeatureFlags/WebKit-ios.plist:
+        * FeatureFlags/WebKit-macos.plist:
+        * FeatureFlags/WebKit-watchos.plist:
+        * Scripts/combine-feature-flags-plist.py:
+        (main): Fix an issue to merge "attributes".
+
 2021-03-30  Jean-Yves Avenard  <[email protected]>
 
         Now Playing content isn't updated when media session's Metadata is modified

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist (275206 => 275207)


--- trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist	2021-03-30 16:31:21 UTC (rev 275206)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-appletvos.plist	2021-03-30 16:32:01 UTC (rev 275207)
@@ -2,85 +2,100 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>async_frame_and_overflow_scrolling</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_canvas_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_dom_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_media</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_webgl</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_webrtc</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>InAppBrowserPrivacy</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>incremental_pdf</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>vp9_decoder</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>WebGL2</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebGPU</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebXR</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>webm_format_reader</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>webm_parser</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>RB_full_manage_WK_jetsam</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
+    <key>async_frame_and_overflow_scrolling</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>gpu_process_canvas_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_dom_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_media</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_webgl</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_webrtc</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>InAppBrowserPrivacy</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>incremental_pdf</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>sw_vp9_decoder_on_battery</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>vp9_decoder</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>WebGL2</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebGPU</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebXR</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>webm_format_reader</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>webm_parser</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>RB_full_manage_WK_jetsam</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
 </dict>
 </plist>

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist (275206 => 275207)


--- trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist	2021-03-30 16:31:21 UTC (rev 275206)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-ios.plist	2021-03-30 16:32:01 UTC (rev 275207)
@@ -2,85 +2,100 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>async_frame_and_overflow_scrolling</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_canvas_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_dom_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_media</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_webgl</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_webrtc</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>InAppBrowserPrivacy</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>incremental_pdf</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>vp9_decoder</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>WebGL2</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebGPU</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebXR</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>webm_format_reader</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>webm_parser</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>RB_full_manage_WK_jetsam</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
+    <key>async_frame_and_overflow_scrolling</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>gpu_process_canvas_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_dom_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_media</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_webgl</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_webrtc</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>InAppBrowserPrivacy</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>incremental_pdf</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>sw_vp9_decoder_on_battery</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>vp9_decoder</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>WebGL2</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebGPU</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebXR</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>webm_format_reader</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>webm_parser</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>RB_full_manage_WK_jetsam</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
 </dict>
 </plist>

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist (275206 => 275207)


--- trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist	2021-03-30 16:31:21 UTC (rev 275206)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-macos.plist	2021-03-30 16:32:01 UTC (rev 275207)
@@ -2,85 +2,100 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>async_frame_and_overflow_scrolling</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_canvas_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_dom_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_media</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_webgl</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_webrtc</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>InAppBrowserPrivacy</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>incremental_pdf</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>vp9_decoder</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>WebGL2</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebGPU</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebXR</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>webm_format_reader</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>webm_parser</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>RB_full_manage_WK_jetsam</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
+    <key>async_frame_and_overflow_scrolling</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>gpu_process_canvas_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_dom_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_media</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_webgl</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_webrtc</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>InAppBrowserPrivacy</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>incremental_pdf</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>sw_vp9_decoder_on_battery</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>vp9_decoder</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>WebGL2</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebGPU</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebXR</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>webm_format_reader</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>webm_parser</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>RB_full_manage_WK_jetsam</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
 </dict>
 </plist>

Modified: trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist (275206 => 275207)


--- trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist	2021-03-30 16:31:21 UTC (rev 275206)
+++ trunk/Source/WebKit/FeatureFlags/WebKit-watchos.plist	2021-03-30 16:32:01 UTC (rev 275207)
@@ -2,85 +2,100 @@
 <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
 <dict>
-	<key>async_frame_and_overflow_scrolling</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_canvas_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_dom_rendering</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_media</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>gpu_process_webgl</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>gpu_process_webrtc</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>InAppBrowserPrivacy</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>incremental_pdf</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>sw_vp9_decoder_on_battery</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>vp9_decoder</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>WebGL2</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebGPU</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>WebXR</key>
-	<dict>
-		<key>Enabled</key>
-		<false/>
-	</dict>
-	<key>webm_format_reader</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>webm_parser</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
-	<key>RB_full_manage_WK_jetsam</key>
-	<dict>
-		<key>Enabled</key>
-		<true/>
-	</dict>
+    <key>async_frame_and_overflow_scrolling</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>gpu_process_canvas_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_dom_rendering</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_media</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>gpu_process_webgl</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>gpu_process_webrtc</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+        <key>Attributes</key>
+        <dict>
+            <key>CodeComplete</key>
+            <true/>
+        </dict>
+    </dict>
+    <key>InAppBrowserPrivacy</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>incremental_pdf</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>sw_vp9_decoder_on_battery</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>vp9_decoder</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>WebGL2</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebGPU</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>WebXR</key>
+    <dict>
+        <key>Enabled</key>
+        <false/>
+    </dict>
+    <key>webm_format_reader</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>webm_parser</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
+    <key>RB_full_manage_WK_jetsam</key>
+    <dict>
+        <key>Enabled</key>
+        <true/>
+    </dict>
 </dict>
 </plist>

Modified: trunk/Source/WebKit/Scripts/combine-feature-flags-plist.py (275206 => 275207)


--- trunk/Source/WebKit/Scripts/combine-feature-flags-plist.py	2021-03-30 16:31:21 UTC (rev 275206)
+++ trunk/Source/WebKit/Scripts/combine-feature-flags-plist.py	2021-03-30 16:32:01 UTC (rev 275207)
@@ -44,7 +44,10 @@
                     print('Error!', key, 'does not exist in' + feature_flags_plist_path)
                     return 1
 
-                feature_flags[key].update(internal_feature_flags[key])
+                if 'Attributes' in feature_flags[key] and 'Attributes' in internal_feature_flags[key]:
+                    feature_flags[key]['Attributes'].update(internal_feature_flags[key]['Attributes'])
+                else:
+                    feature_flags[key].update(internal_feature_flags[key])
 
             with open(output_plist_path, 'wb') as output_plist_file:
                 plistlib.dump(feature_flags, output_plist_file)

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes