Title: [275226] trunk/Tools
- Revision
- 275226
- Author
- [email protected]
- Date
- 2021-03-30 12:17:38 -0700 (Tue, 30 Mar 2021)
Log Message
[resultsdbpy] Return new-style commits (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=223262
<rdar://problem/75483361>
Unreviewed follow-up fix.
* Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py:
(CommitController.register): Allow branch in commit uploads.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (275225 => 275226)
--- trunk/Tools/ChangeLog 2021-03-30 19:14:56 UTC (rev 275225)
+++ trunk/Tools/ChangeLog 2021-03-30 19:17:38 UTC (rev 275226)
@@ -1,3 +1,14 @@
+2021-03-30 Jonathan Bedard <[email protected]>
+
+ [resultsdbpy] Return new-style commits (Follow-up fix)
+ https://bugs.webkit.org/show_bug.cgi?id=223262
+ <rdar://problem/75483361>
+
+ Unreviewed follow-up fix.
+
+ * Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py:
+ (CommitController.register): Allow branch in commit uploads.
+
2021-03-30 Jessie Berlin <[email protected]>
Reinstate my committer status.
Modified: trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py (275225 => 275226)
--- trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py 2021-03-30 19:14:56 UTC (rev 275225)
+++ trunk/Tools/Scripts/libraries/resultsdbpy/resultsdbpy/controller/commit_controller.py 2021-03-30 19:17:38 UTC (rev 275226)
@@ -308,9 +308,9 @@
for arg in commit.keys():
- if arg in required_args or arg in one_of_args:
+ if arg in required_args or arg in one_of_args or arg in ['branch']:
continue
- if arg in ['branch', 'timestamp', 'order', 'committer', 'message']:
+ if arg in ['timestamp', 'order', 'committer', 'message']:
abort(400, description='Not enough arguments provided to define a commit, but too many to search for a commit')
abort(400, description=f"'{arg}' is not valid for defining commits")
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
