Title: [275265] trunk/LayoutTests
- Revision
- 275265
- Author
- [email protected]
- Date
- 2021-03-30 21:20:07 -0700 (Tue, 30 Mar 2021)
Log Message
[Catalina WK2] 5 media/modern-media-controls/tracks-support tests consistently timing out
https://bugs.webkit.org/show_bug.cgi?id=223673
<rdar://problem/75769577>
Unreviewed, check that the `subtitlesMenu` exists before attempting to look at its `children`.
* media/modern-media-controls/tracks-support/auto-text-track.html:
* media/modern-media-controls/tracks-support/click-track-in-contextmenu.html:
* media/modern-media-controls/tracks-support/hidden-tracks.html:
* media/modern-media-controls/tracks-support/off-text-track.html:
* media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (275264 => 275265)
--- trunk/LayoutTests/ChangeLog 2021-03-31 04:18:12 UTC (rev 275264)
+++ trunk/LayoutTests/ChangeLog 2021-03-31 04:20:07 UTC (rev 275265)
@@ -1,3 +1,17 @@
+2021-03-30 Devin Rousso <[email protected]>
+
+ [Catalina WK2] 5 media/modern-media-controls/tracks-support tests consistently timing out
+ https://bugs.webkit.org/show_bug.cgi?id=223673
+ <rdar://problem/75769577>
+
+ Unreviewed, check that the `subtitlesMenu` exists before attempting to look at its `children`.
+
+ * media/modern-media-controls/tracks-support/auto-text-track.html:
+ * media/modern-media-controls/tracks-support/click-track-in-contextmenu.html:
+ * media/modern-media-controls/tracks-support/hidden-tracks.html:
+ * media/modern-media-controls/tracks-support/off-text-track.html:
+ * media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html:
+
2021-03-30 Carlos Alberto Lopez Perez <[email protected]>
[GTK][WPE] Gardening of tests.
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/auto-text-track.html (275264 => 275265)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/auto-text-track.html 2021-03-31 04:18:12 UTC (rev 275264)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/auto-text-track.html 2021-03-31 04:20:07 UTC (rev 275265)
@@ -29,7 +29,7 @@
pressOnElement(shadowRoot.querySelector("button.tracks")),
]);
let subtitlesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Subtitles");
- if (subtitlesMenu.children?.length) {
+ if (subtitlesMenu?.children?.length) {
await UIHelper.chooseMenuAction(subtitlesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
contextmenu = [subtitlesMenu];
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/click-track-in-contextmenu.html (275264 => 275265)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/click-track-in-contextmenu.html 2021-03-31 04:18:12 UTC (rev 275264)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/click-track-in-contextmenu.html 2021-03-31 04:20:07 UTC (rev 275265)
@@ -42,7 +42,7 @@
debug("Selecting 'French' track...");
let contextmenu = await getTracksContextMenu();
let languagesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Languages");
- if (languagesMenu.children?.length) {
+ if (languagesMenu?.children?.length) {
await UIHelper.chooseMenuAction(languagesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
}
@@ -54,7 +54,7 @@
debug("Selecting 'Spanish' track...");
let contextmenu = await getTracksContextMenu();
let languagesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Languages");
- if (languagesMenu.children?.length) {
+ if (languagesMenu?.children?.length) {
await UIHelper.chooseMenuAction(languagesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
}
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/hidden-tracks.html (275264 => 275265)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/hidden-tracks.html 2021-03-31 04:18:12 UTC (rev 275264)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/hidden-tracks.html 2021-03-31 04:20:07 UTC (rev 275265)
@@ -30,7 +30,7 @@
pressOnElement(shadowRoot.querySelector("button.tracks")),
]);
let subtitlesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Subtitles");
- if (subtitlesMenu.children?.length) {
+ if (subtitlesMenu?.children?.length) {
await UIHelper.chooseMenuAction(subtitlesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
contextmenu = [subtitlesMenu];
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/off-text-track.html (275264 => 275265)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/off-text-track.html 2021-03-31 04:18:12 UTC (rev 275264)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/off-text-track.html 2021-03-31 04:20:07 UTC (rev 275265)
@@ -26,7 +26,7 @@
pressOnElement(shadowRoot.querySelector("button.tracks")),
]);
let subtitlesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Subtitles");
- if (subtitlesMenu.children?.length) {
+ if (subtitlesMenu?.children?.length) {
await UIHelper.chooseMenuAction(subtitlesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
contextmenu = [subtitlesMenu];
Modified: trunk/LayoutTests/media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html (275264 => 275265)
--- trunk/LayoutTests/media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html 2021-03-31 04:18:12 UTC (rev 275264)
+++ trunk/LayoutTests/media/modern-media-controls/tracks-support/text-track-selected-via-media-api.html 2021-03-31 04:20:07 UTC (rev 275265)
@@ -39,7 +39,7 @@
pressOnElement(shadowRoot.querySelector("button.tracks")),
]);
let subtitlesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Subtitles");
- if (subtitlesMenu.children?.length) {
+ if (subtitlesMenu?.children?.length) {
await UIHelper.chooseMenuAction(subtitlesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
contextmenu = [subtitlesMenu];
@@ -62,7 +62,7 @@
pressOnElement(shadowRoot.querySelector("button.tracks")),
]);
let subtitlesMenu = contextmenu[0].children.find((submenu) => submenu.title === "Subtitles");
- if (subtitlesMenu.children?.length) {
+ if (subtitlesMenu?.children?.length) {
await UIHelper.chooseMenuAction(subtitlesMenu.title);
await UIHelper.delayFor(500); // give time for the UIMenu to animate
contextmenu = [subtitlesMenu];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
