Title: [275429] trunk/Source/WebKit
Revision
275429
Author
[email protected]
Date
2021-04-02 11:52:16 -0700 (Fri, 02 Apr 2021)

Log Message

Capture rotation is wrong after Safari is backgrounded then foregrounded
https://bugs.webkit.org/show_bug.cgi?id=224103

Reviewed by Eric Carlson.

WebPage computes rotation either based on rotation notification or viewport notification.
Apply the same technique in UIProcess to let GPUProcess get the right information.
Manually tested.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (275428 => 275429)


--- trunk/Source/WebKit/ChangeLog	2021-04-02 18:40:03 UTC (rev 275428)
+++ trunk/Source/WebKit/ChangeLog	2021-04-02 18:52:16 UTC (rev 275429)
@@ -1,5 +1,19 @@
 2021-04-02  Youenn Fablet  <[email protected]>
 
+        Capture rotation is wrong after Safari is backgrounded then foregrounded
+        https://bugs.webkit.org/show_bug.cgi?id=224103
+
+        Reviewed by Eric Carlson.
+
+        WebPage computes rotation either based on rotation notification or viewport notification.
+        Apply the same technique in UIProcess to let GPUProcess get the right information.
+        Manually tested.
+
+        * UIProcess/ios/WebPageProxyIOS.mm:
+        (WebKit::WebPageProxy::dynamicViewportSizeUpdate):
+
+2021-04-02  Youenn Fablet  <[email protected]>
+
         Do not send samples to GPUProcess if mediastream video is not playing
         https://bugs.webkit.org/show_bug.cgi?id=224100
         <rdar://74809558>

Modified: trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm (275428 => 275429)


--- trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm	2021-04-02 18:40:03 UTC (rev 275428)
+++ trunk/Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm	2021-04-02 18:52:16 UTC (rev 275429)
@@ -275,6 +275,8 @@
         maximumUnobscuredSize, targetExposedContentRect, targetUnobscuredRect,
         targetUnobscuredRectInScrollViewCoordinates, unobscuredSafeAreaInsets,
         targetScale, deviceOrientation, minimumEffectiveDeviceWidth, dynamicViewportSizeUpdateID), m_webPageID);
+
+    setDeviceOrientation(deviceOrientation);
 }
 
 void WebPageProxy::setViewportConfigurationViewLayoutSize(const WebCore::FloatSize& size, double scaleFactor, double minimumEffectiveDeviceWidth)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to